SMAA and FSR: The 2nd Runner #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Expose all the configuration settings used by the quality presets to allow fine-tuning of edge detection. - Changed default edge detection technique from luma to color since in my tests that always yields better results. - Increased quality to ultra in default preset. - Deleted the duplication of the fragment shader part of the lib, as I figured out how to include the lib twice with different defines for the vertex and fragment passes. That is necessary probably because discard cannot be used in vertex shaders in RetroArch, indicated in a comment in the lib as a possible restriction in some compilers. - Include license headers to make clear that all my contributions are released on the public domain under the terms of the Unlicense. Anyone can do whatever they want with this.
- New implementation of Film Grain that doesn't suck, so we can turn it up a nod by default. Supports RGB noise and shaping the distribution curve to control noise modulation. The previous implementation was just a placeholder, it was very basic. - Greatly increased Anti-Aliasing quality in default preset. - Include license headers to make clear that all my contributions are released on the public domain under the terms of the Unlicense. Anyone can do whatever they want with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm back with the same thing again, but bigger, better, stronger. Exposed every little bit of configuration from SMAA and extensively wasted my life tweaking every possible setting to get the last drop of quality I could get out of SMAA. The result looks AMAZING! It's on a whole 'nother level now!
On the FSR front, I implemented proper Film Grain, not that garbage I had put there before just to tick a feature box and get paid at the end of the month. No, this isn't my job, it deserves much more respect than that.
I'm proud of what I have achieved here, I can finally rest now.
PS. Sorry for the tone, I'm on sleep deprivation.