Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

npm ignore, readme and vendor forge #10

Merged
merged 1 commit into from
Apr 12, 2016
Merged

Conversation

daviddias
Copy link
Member

@dignifiedquire getting a weird error only on PhantomJS. Thoughts?

07 04 2016 20:04:40.805:INFO [PhantomJS 1.9.8 (Mac OS X 0.0.0)]: Connected on socket /#GBB6R-4b3sJGWx54AAAB with id 36302288
PhantomJS 1.9.8 (Mac OS X 0.0.0) ERROR
  SyntaxError: Parse error
  at /Users/david/code/protocol-labs/_libp2p/js/js-peer-info/test/index.spec.js:20710


  7 passing (29s)

[20:04:40] 'karma' errored after 29 s
[20:04:40] Error: Some tests are failing
    at formatError (/Users/david/code/protocol-labs/_libp2p/js/js-peer-info/node_modules/dignified.js/src/gulp-log.js:24:10)
    at Gulp.<anonymous> (/Users/david/code/protocol-labs/_libp2p/js/js-peer-info/node_modules/dignified.js/src/gulp-log.js:50:17)
    at emitOne (events.js:82:20)
    at Gulp.emit (events.js:169:7)
    at Gulp.Orchestrator._emitTaskDone (/Users/david/code/protocol-labs/_libp2p/js/js-peer-info/node_modules/orchestrator/index.js:264:8)
    at /Users/david/code/protocol-labs/_libp2p/js/js-peer-info/node_modules/orchestrator/index.js:275:23
    at finish (/Users/david/code/protocol-labs/_libp2p/js/js-peer-info/node_modules/orchestrator/lib/runTask.js:21:8)
    at cb (/Users/david/code/protocol-labs/_libp2p/js/js-peer-info/node_modules/orchestrator/lib/runTask.js:29:3)

@daviddias daviddias force-pushed the last-dignified-touches branch from 289dc8e to fb2102a Compare April 12, 2016 18:58
@daviddias
Copy link
Member Author

ok, so PhantomJS error was because I had a older version. Now I have a new error:

AAB with id 32204495
PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
  SyntaxError: Unexpected token 'const'
  at /Users/david/code/protocol-labs/_libp2p/js/js-peer-info/test/index.spec.js:20708

@daviddias daviddias force-pushed the last-dignified-touches branch from fb2102a to 106a06b Compare April 12, 2016 19:52
.npm

# Optional REPL history
.node_repl_history
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test should be ignored as well

@dignifiedquire
Copy link
Member

SyntaxError: Unexpected token 'const'

This means that one of your dependencies is not being properly transpiled into ES5. Try

  • running DEBUG=1 npm run test:browse
  • Click the debug button in the chrome window
  • Go to devtools sources panel
  • Open index.spec.js and search for const from the results you should be able to see which modules are not transpiled

@daviddias
Copy link
Member Author

Found the issue. Seems that peer-id didn't have jsnext:main defined and so this module thought it was using already the transpiled version (and so, not transpiling it)

The new issue is that js-peer-id also breaks on PhantomJS with:

12 04 2016 21:06:03.040:INFO [launcher]: Starting browser PhantomJS

12 04 2016 21:07:03.039:WARN [launcher]: PhantomJS have not captured in 60000 ms, killing.
12 04 2016 21:07:05.040:WARN [launcher]: PhantomJS was not killed in 2000 ms, sending SIGKILL.
12 04 2016 21:07:07.045:WARN [launcher]: PhantomJS was not killed by SIGKILL in 2000 ms, continuing.

libp2p/js-peer-id#17

@daviddias daviddias force-pushed the last-dignified-touches branch from 106a06b to 7fb7b53 Compare April 12, 2016 20:33
@daviddias
Copy link
Member Author

Now yes :) As a reference (for the lolz) -> libp2p/js-peer-id#17 (comment)

@daviddias daviddias merged commit d9b1942 into master Apr 12, 2016
@daviddias daviddias deleted the last-dignified-touches branch April 12, 2016 20:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants