Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsnext add #17

Merged
merged 1 commit into from
Apr 12, 2016
Merged

jsnext add #17

merged 1 commit into from
Apr 12, 2016

Conversation

daviddias
Copy link
Member 

12 04 2016 21:06:03.040:INFO [launcher]: Starting browser PhantomJS

12 04 2016 21:07:03.039:WARN [launcher]: PhantomJS have not captured in 60000 ms, killing.
12 04 2016 21:07:05.040:WARN [launcher]: PhantomJS was not killed in 2000 ms, sending SIGKILL.
12 04 2016 21:07:07.045:WARN [launcher]: PhantomJS was not killed by SIGKILL in 2000 ms, continuing.

@daviddias daviddias mentioned this pull request Apr 12, 2016
Merged
@daviddias
Copy link
Member Author

Woooo, thank you Travis-Ci for existing. I was actually struggling to get this working on my machine, thinking it was some mistake in how we do transpilation because we are importing node-forge as a special case, but in the end, it was just my PhantomJS dep that was old and crashed all the things! Fortunately, thanks to Travis-Ci, I saw the green checkmarks and decided to change my strategy. It works now. Wooowow :D

@daviddias daviddias merged commit e45a9f4 into master Apr 12, 2016
@daviddias daviddias deleted the jsnext-add branch April 12, 2016 20:24
dignifiedquire
dignifiedquire reviewed Apr 12, 2016
View reviewed changes
package.json
@@ -2,7 +2,8 @@
"name": "peer-id",
"version": "0.6.4",
"description": "IPFS Peer Id implementation in Node.js",
"main": "src/index.js",
"main": "lib/index.js",
"jsnext": "src/index.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be jsnext:main as far as I know

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for a moment, I thought I actually had never fixed anything. But updated here and all still seems good:

#18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daviddias @dignifiedquire