-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for specifying keys #85
Conversation
I am going to do some integration tests against libp2p and js-ipfs with the |
7e7e0c7
to
3eba50b
Compare
I ran this through the Aside from a minor issue with the This should be good to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
3eba50b
to
205cd3f
Compare
@pgte I rebased this off the latest release, let me know if there are any updates you need from me for this to be released. |
@jacobheun there's a ticket in https://github.com/libp2p/js-libp2p-crypto-secp256k1 to support secp keys in the latest libp2p. You can't unmarshal private keys since the underlying signature changed in peerId (https://github.com/libp2p/js-libp2p-crypto-secp256k1/pulls). Is there any reason to keep secp256 in it's own package at this point? Isn't it directly included in libp2p crypto now? Apologies if this is the wrong place to discuss. |
@blakebyrnes I created an issue at libp2p-crypto to discuss this libp2p/js-libp2p-crypto#135, since it should probably happen there. |
Closing, as this was added on #95 |
libp2p-crypto
already supports multiple key formats, this PR exposes that by adding the type option to.create
. This will allow users to create the other key types more easily.