Return type from generateKeyPair is inconsistent

[achingbrain]

If you specify rsa as the key type, you get an object with an export method. If you specify ed25519 you don't, which leads to:

$ jsipfs key gen -t rsa my-rsa-key
generated QmSdrjFr32xsvt6yLnD8LS8Uc4riNnRUS4eLT6qogYT2P9 my-rsa-key
$ jsipfs key gen -t ed25519 my-ed25519-key
/path/to/js-libp2p-keychain/src/keychain.js:206
          keypair.export(this._(), (err, pem) => {
                        ^

TypeError: keypair.export is not a function
    at keypair.id (/path/to/js-libp2p-keychain/src/keychain.js:206:25)
    at public.hash (/path/to/js-ipfs/node_modules/libp2p-crypto/src/keys/ed25519-class.js:97:7)
    at Multihashing.Multihashing.digest (/path/to/js-ipfs/node_modules/libp2p-crypto/node_modules/multihashing-async/src/index.js:33:5)
...

Go does not have the same problem:

$ ipfs key gen -t rsa my-rsa-key
QmTtWZKxgxkyGG4B7uW7eqkNPyuTKGwFGaqJx34hF8SCVL
$ ipfs key gen -t ed25519 my-ed25519-key
12D3KooWNXoeAFst3J9AUeJiKxcjecZL2v16Kq3UfVqK1ADWeaS5

[achingbrain]

Digging a bit deeper it looks like ed25519 support was added to go-ipfs in response to ipfs/notes#241 (though it seems to stall on a discussion about first converting peer IDs to be v1 CIDs) and is awaiting ipfs/kubo#3896 to be merged. Full support never seems to have made it to js-ipfs.

[jacobheun]

This is a blocker for libp2p/js-peer-id#85 that I am going to be looking into.

[lidel]

ed25519 keys are the default in js-ipfs these days, this was fixed a while ago

$ jsipfs key gen -t rsa my-rsa-key 
generated QmPMwGnukVx2HKPHGGUg91MStuKwmePbLb78BuAzM9K73i my-rsa-key

$ jsipfs key gen -t ed25519 my-ed25519-key
generated 12D3KooWFBU6aMwR5DPzEZJD5jdFPnkXw8iB69HNytJq3kdikp5b my-ed25519-key