docs: use Libp2p.create() in examples (#811) #814

a1300 · 2020-11-26T18:11:21Z

I didn't changed the use of new Libp2p() in the examples/delegated-routing directory because this is already in progress in PR #507

js-libp2p/examples/delegated-routing/src/libp2p-bundle.js

Lines 23 to 30 in d0a9fad

    
           return new Libp2p({ 
        
             peerInfo, 
        
             peerBook, 
        
             // Lets limit the connection managers peers and have it check peer health less frequently 
        
             connectionManager: { 
        
               maxPeers: 10, 
        
               pollInterval: 5000 
        
             },

vasco-santos

Thanks for the PR. Except for my two comments in the API doc, everything looks good

doc/API.md

vasco-santos

LGTM

docs: use Libp2p.create() in examples (#811)

e2d994e

vasco-santos suggested changes Nov 27, 2020

View reviewed changes

doc/API.md Outdated Show resolved Hide resolved

doc/API.md Outdated Show resolved Hide resolved

docs: add required Libp2p modules (#811)

c3af0ef

a1300 requested a review from vasco-santos November 27, 2020 12:18

vasco-santos approved these changes Nov 30, 2020

View reviewed changes

vasco-santos merged commit 7320495 into libp2p:master Nov 30, 2020

a1300 deleted the docs_libp2p_create_example branch November 30, 2020 12:21

a1300 mentioned this pull request Dec 7, 2020

Preferred way to instantiate Libp2p bundle? Inherit or static create? #811

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: use Libp2p.create() in examples (#811) #814

docs: use Libp2p.create() in examples (#811) #814

a1300 commented Nov 26, 2020 •

edited

Loading

vasco-santos left a comment

vasco-santos left a comment

	return new Libp2p({
	peerInfo,
	peerBook,
	// Lets limit the connection managers peers and have it check peer health less frequently
	connectionManager: {
	maxPeers: 10,
	pollInterval: 5000
	},

docs: use Libp2p.create() in examples (#811) #814

docs: use Libp2p.create() in examples (#811) #814

Conversation

a1300 commented Nov 26, 2020 • edited Loading

vasco-santos left a comment

Choose a reason for hiding this comment

vasco-santos left a comment

Choose a reason for hiding this comment

a1300 commented Nov 26, 2020 •

edited

Loading