-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: examples/delegated-routing #507
Conversation
fd049f1
to
aa9a5ba
Compare
"react": "^16.8.6", | ||
"react-dom": "^16.8.6", | ||
"react-scripts": "2.1.8" | ||
"ipfs": "~0.40.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to get libp2p
to js-ipfs
before getting this to work.
However, I could also not test this with #master . Do we need to run go-ipfs
in the specific branch mentioned in the README?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some configuration issues that need to be resolved, see #371 (review).
In regards to requiring ipfs
, we may want to revisit this example and only have libp2p in the client. The example cats a file right now, but in reality we just need to find things on the network via the delegate node.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this example, should we have a js-libp2p
node running and providing a few cid that we can then find with the app example?
374ceb4
to
45f4702
Compare
aa9a5ba
to
0f13e53
Compare
0f13e53
to
b7c782f
Compare
b7c782f
to
1eaf761
Compare
examples/delegated-routing/.env
Outdated
@@ -0,0 +1,3 @@ | |||
# required because react-scripts scans *up* the tree from this project and finds | |||
# a conflicting version of eslint in the node_modules dir for js-ipfs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary? js-ipfs doesn't have a runtime dependency on eslint? Maybe if this example was in the js-ipfs repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed. I copied this from the react example of js-ipfs
, but did not read the comment: https://github.com/ipfs/js-ipfs/blob/master/examples/browser-create-react-app/.env
It is aegir that installs a version of webpack
that is not compatible with react-scripts
. I am going to change that comment
After syncing with @jacobheun , we will start by having a public delegated router configured. We were having some issues finding peer via the delegate because of the lack of support for HTTPS in the |
Superseded by #1390 |
This PR refactors the
delegated-routing
example to the refactored asyncjs-libp2p
.