Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

CMS - PKCS #7 #19

Merged
merged 11 commits into from
Jan 29, 2018
Merged

CMS - PKCS #7 #19

merged 11 commits into from
Jan 29, 2018

Conversation

richardschneider
Copy link
Contributor

A proposal for creating cryptographic protected data using the key chain. It uses PKCS #7 aka RFC 5652 to encrypt the data.

This can be used to implement ipfs crypt encrypt and ipfs crypt decrypt in spec keystore

@richardschneider richardschneider changed the title CMS - PKCS 8 CMS - PKCS #7 Dec 22, 2017
@richardschneider richardschneider mentioned this pull request Dec 22, 2017
Merged
6 tasks
@richardschneider
Copy link
Contributor Author

This spec is missing a verification and signing.

@richardschneider
Copy link
Contributor Author

Verification requires the keychain to manage public keys. Does verification fail if a public key is missing for a signer? Are multiple signers allowed?

@richardschneider richardschneider changed the title CMS - PKCS #7 [WIP] CMS - PKCS #7 Dec 28, 2017
@richardschneider
Copy link
Contributor Author

richardschneider commented Dec 31, 2017 •
edited
Loading

@diasdavid These test are randomly failing because libp2p-crypto is slow. Can you review/merge/release libp2p/js-libp2p-crypto#117?

daviddias
daviddias approved these changes Jan 28, 2018
View reviewed changes
.travis.yml

before_script:
- export DISPLAY=:99.0
- sh -e /etc/init.d/xvfb start

after_success:
- npm run coverage-publish

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem that coverage got added to Circle https://github.com/libp2p/js-libp2p-keychain/blob/master/circle.yml

@daviddias
Copy link
Member

@richardschneider updated deps and rebased master onto this branch. Mind checking why there are failures? You need a release of keychain with this PR, right?

@richardschneider
Copy link
Contributor Author

@diasdavid Thanks for the fast response.

No, I just need the current master to update its deps and release to NPM. However, I will try to determine why this failed.

@richardschneider
Copy link
Contributor Author

@diasdavid Its a problem with the latest deepmerge, see TehShrike/deepmerge#87 (comment). They do not believe its an problem!

Please rollback to "deepmerge": "^1.5.2",

@daviddias
Copy link
Member

@richardschneider is this ready as well?

@richardschneider richardschneider changed the title [WIP] CMS - PKCS #7 CMS - PKCS #7 Jan 29, 2018
@richardschneider
Copy link
Contributor Author

@diasdavid Yes its RTM. I was just waiting for other stuff to settle down.

daviddias
daviddias approved these changes Jan 29, 2018
View reviewed changes
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏽

@daviddias daviddias merged commit 5560669 into master Jan 29, 2018
@daviddias daviddias deleted the cms branch January 29, 2018 06:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daviddias daviddias daviddias approved these changes

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardschneider @daviddias