-
Notifications
You must be signed in to change notification settings - Fork 52
Improve speed #117
Improve speed #117
Conversation
@richardschneider have you tried npm linking this package to its dependents and run the tests? The tricky part with UMD comes appears when you try to require a module that has a dependency using it. |
Not sure what you want to |
Interesting, that seems to be the case now https://www.npmjs.com/package/node-forge#installation ✨ I'll test this ASAP. Thanks @richardschneider :) |
@diasdavid Thanks. IMHO node-forge is a better package than |
@diasdavid LGTM |
@diasdavid This is open for over a month. Are there any issues? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small note. Testing it now
src/keys/rsa-class.js
Outdated
@@ -121,21 +121,30 @@ class RsaPrivateKey { | |||
* @returns {undefined} | |||
*/ | |||
export (format, password, callback) { | |||
const self = this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never gets used.
jsrsasign
is 2 orders of magnitude slower thatnode-forge
; see the benchmarks.node-forge is a little bigger than jsrsasign (273 kB vs 259 kB).
libp2p-crypto
relies uponkeypair
for RSA. It is 128 kB.keypair
has copiednode-forge
code from 5 years ago and has added JWK support. If we make a JWK PR to forge, then we can remove the thekeypair
dependency.