This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
Improve speed #117
Merged
Improve speed #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@richardschneider have you tried npm linking this package to its dependents and run the tests? The tricky part with UMD comes appears when you try to require a module that has a dependency using it. |
|
Not sure what you want to |
|
Interesting, that seems to be the case now https://www.npmjs.com/package/node-forge#installation ✨ I'll test this ASAP. Thanks @richardschneider :) |
|
@diasdavid Thanks. IMHO node-forge is a better package than |
|
@diasdavid LGTM |
|
@diasdavid This is open for over a month. Are there any issues? |
daviddias
suggested changes
Jan 27, 2018
src/keys/rsa-class.js
Outdated
| @@ -121,21 +121,30 @@ class RsaPrivateKey { | |||
| * @returns {undefined} | |||
| */ | |||
| export (format, password, callback) { | |||
| const self = this | |||
daviddias
approved these changes
Jan 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsrsasignis 2 orders of magnitude slower thatnode-forge; see the benchmarks.node-forge is a little bigger than jsrsasign (273 kB vs 259 kB).
libp2p-cryptorelies uponkeypairfor RSA. It is 128 kB.keypairhas copiednode-forgecode from 5 years ago and has added JWK support. If we make a JWK PR to forge, then we can remove the thekeypairdependency.