Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tests #631

Merged
merged 3 commits into from
Jun 19, 2017
Merged

Fix Tests #631

merged 3 commits into from
Jun 19, 2017

Conversation

pietbrauer
Copy link
Member

I rebased onto master and made the tests compile on Xcode 8.3 with the following trade-offs:

  • Turn off treat warnings as errors only for the iOS Tests
  • Disable should be built with SSH enabled test on macOS

I think the trade-offs are worth it considering we have a green test suite again.

Closes #599

@pietbrauer pietbrauer requested a review from tiennou May 29, 2017 21:14
This was referenced May 29, 2017
Merged
Closed
tiennou
tiennou approved these changes Jun 19, 2017
View reviewed changes
Copy link
Contributor

@tiennou tiennou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! I ran that locally, and it seems Travis was happy too, so 👍.

@tiennou tiennou merged commit 90f3d41 into master Jun 19, 2017
@tiennou tiennou deleted the tiennou/travis-fix branch March 1, 2018 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiennou tiennou tiennou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pietbrauer @tiennou