Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merge analysis between two branches #629

Closed
wants to merge 5 commits into from

Conversation

alehed
Copy link
Contributor

@alehed alehed commented May 28, 2017

If you want to check the feasibility of a merge between two branches, this might come in handy.

Copy link
Member

@pietbrauer pietbrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! Tests would be very nice here as well.

@alehed
Copy link
Contributor Author

alehed commented Jun 5, 2017

To my knowledge there is no way to get ObjectiveGit to give me an "unborn" branch, that is one with an empty SHA, so GTMergeAnalysisUnborn is never returned.

@alehed
Copy link
Contributor Author

alehed commented Jun 5, 2017

Any idea why the test fails? Locally the (iOS) tests all succeed with the newer versions of Quick and Nimble.

@pietbrauer
Copy link
Member

My guess is that we are still running tests with Xcode 8.0 on Travis until #631 is merged. There could be some changes in Xcode and/or Nimble and Quick that cause this.

@alehed
Copy link
Contributor Author

alehed commented Jul 9, 2017

Hope the tests pass now.

@tiennou
Copy link
Contributor

tiennou commented Jul 9, 2017

About "unborn" : you can get one by deleting the ref pointed to by HEAD.

Since you can only merge a branch in HEAD, I'm wondering about the use case for that method.

@alehed
Copy link
Contributor Author

alehed commented Jul 10, 2017

The reason why I needed this is for pulling a branch other than the current one. Think git pull origin master while you are on branch feature-1.

What I meant was that since the method takes branches, there is no way to pass it the nonexistent target of head, which means GTMergeAnalysisUnborn is never passed out by itself (even though the SHA property is Nullable).

Btw, feel free to sqash merge this, I realized I merged master into it instead of rebasing ontop of it.

@tiennou
Copy link
Contributor

tiennou commented Jul 17, 2017

@pks-t @ethomson Would you guys be interested in having that capability upstream ? I'm a little wary of adding API not backed by what's in The Library...

@ethomson
Copy link
Member

Yeah; it seems that this is similar to giving git_merge_analysis the knowledge of a different ours. I can see how that would be useful.

@alehed
Copy link
Contributor Author

alehed commented Nov 8, 2021

Now with upstream having this feature, the PR would have to be reworked completely. I'm not working on this any more, so closing.

@alehed alehed closed this Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants