-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P093 Mitsubishi HeatPump - Add Remote Temperature #4809
Conversation
An uint8_t is unsigned, it cannot be -127-0 ... |
If you add |
Thanks, done... |
I see you haven't been pointed at the Developer documentation/guide for ESPEasy yet, that also includes the Github shenanigans you have to go through 😸 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's desirable that you are adding these (empty) files, nor changing their permissions...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these (empty) files included?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got no idea? i will close this pr.. i went through the docs you told me and iam a closer to making it working. will do a new pr when its running on my esp. sorry for these troubles...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you just give me a hint how i can set up a test environement just for plugin p093 not to compile each time all plugins containing collection_d_esp8266_4m1m...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My usual mode of operation is to change the pre_custom_esp82xx.py
file, adding/enabling the plugin I'm working on (don't include these changes in your PR please), and then build the PIO environment custom_ESP8266_4M1M
.
After the initial full build, the next time it should only compile the changed files (it will always generate & compile ESPEasy.ino.c
), plus a bunch of framework files (don't know yet how to suppress that 😞). That usually builds quite quick, but still depends on the speed of your computer.
The dependency checks by PIO are also a rather slow part of the process, not much we can do about that, other than throw more 'iron' at it 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, got it... Will try this for the next build :_) Thanks a lot for your help.. Am just a beginner ;-)
Correction of initial PR
Resolves #4711