Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P093 Mitsubishi HeatPump - Add Remote Temperature #4809

Closed
wants to merge 4 commits into from
Closed

P093 Mitsubishi HeatPump - Add Remote Temperature #4809

wants to merge 4 commits into from

Conversation

jfmennedy
Copy link
Contributor

@jfmennedy jfmennedy commented Sep 19, 2023

Correction of initial PR
Resolves #4711

@jfmennedy
Copy link
Contributor Author

But why it is used the same way in line 352 to set temperature?

An uint8_t is unsigned, it cannot be -127-0 ...

@tonhuisman
Copy link
Contributor

If you add Resolves #.... (filling the issue number at the dots), your PR will close the issue once it's merged. (GH Documentation on those keywords is here)

@jfmennedy
Copy link
Contributor Author

If you add Resolves #.... (filling the issue number at the dots), your PR will close the issue once it's merged. (GH Documentation on those keywords is here)

Thanks, done...

@tonhuisman
Copy link
Contributor

I see you haven't been pointed at the Developer documentation/guide for ESPEasy yet, that also includes the Github shenanigans you have to go through 😸

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's desirable that you are adding these (empty) files, nor changing their permissions...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these (empty) files included?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got no idea? i will close this pr.. i went through the docs you told me and iam a closer to making it working. will do a new pr when its running on my esp. sorry for these troubles...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you just give me a hint how i can set up a test environement just for plugin p093 not to compile each time all plugins containing collection_d_esp8266_4m1m...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My usual mode of operation is to change the pre_custom_esp82xx.py file, adding/enabling the plugin I'm working on (don't include these changes in your PR please), and then build the PIO environment custom_ESP8266_4M1M.
After the initial full build, the next time it should only compile the changed files (it will always generate & compile ESPEasy.ino.c), plus a bunch of framework files (don't know yet how to suppress that 😞). That usually builds quite quick, but still depends on the speed of your computer.
The dependency checks by PIO are also a rather slow part of the process, not much we can do about that, other than throw more 'iron' at it 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, got it... Will try this for the next build :_) Thanks a lot for your help.. Am just a beginner ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P093 - Mitsubishi Heat Pump Add Remote Temperature
3 participants