Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P093 - Mitsubishi Heat Pump Add Remote Temperature #4711

Closed
jfmennedy opened this issue Jun 20, 2023 · 4 comments · Fixed by #4813
Closed

P093 - Mitsubishi Heat Pump Add Remote Temperature #4711

jfmennedy opened this issue Jun 20, 2023 · 4 comments · Fixed by #4813
Labels
Category: Plugin Related to supported sensors Type: Enhancement Improve something already present

Comments

@jfmennedy
Copy link
Contributor

Hello,

might it be possible to add setRemoteTemperature to Plugin 093 as implemented at SwiCago https://github.com/SwiCago/HeatPump/blob/e9fc858374b340a54b4f31fac6423af61b7b77f2/src/HeatPump.cpp#L273

That would be nice and improve the operating of internal devices as the internal temperature sensor is not as reliable to match the real room temperature

Thx, Jan
@TD-er TD-er added Type: Enhancement Improve something already present Category: Plugin Related to supported sensors labels Jun 20, 2023
@crnjan
Copy link
Contributor

crnjan commented Jun 23, 2023

Shouldn't be too hard to add, will check when there is a bit of (free?) time ...

@jfmennedy
Copy link
Contributor Author

Hi, is there any news on this ?

@jfmennedy
Copy link
Contributor Author

jfmennedy commented Sep 19, 2023 •
edited
Loading

Well I tried it myself, and created a PR.. Might be reviewed before release...
#4809

@jfmennedy jfmennedy mentioned this issue Sep 19, 2023
Closed
jfmennedy added a commit to jfmennedy/ESPEasy that referenced this issue Sep 21, 2023
@jfmennedy
P093 Mitsubishi HeatPump
98af072 
Add Support for SetRemoteTemperature
Resolves P093 - Mitsubishi Heat Pump Add Remote Temperature letscontrolit#4711
@jfmennedy jfmennedy mentioned this issue Sep 21, 2023
Merged
@jfmennedy
Copy link
Contributor Author

someone can help here?:

#4813 (comment)

erstec added a commit to ly1bwb/ESPEasy that referenced this issue Feb 20, 2024
@erstec
Merge tag 'mega-20231130' into mega_vurk_dmr
b35dc9a 
Release mega-20231130

Changes in mega-20231130 (since mega-20231013):

Fabio Ancona (3):
      Update Custom-sample.h with missing Plugins and update description
      Update Custom-sample.h after review
      Details supported hardware

TD-er (19):
      [WiFi] Fix force B/G mode on ESP8266
      [WiFi] Limit WiFi speed to HT20 for 802.11n mode on ESP32
      [Build] Fix compile error when using default Custom.h (letscontrolit#4870)
      [CDN URL] Add default CDN url with latest tag when no pygit2 installed
      [WiFi] Fix connect to Hidden SSID on Mikrotik AP (letscontrolit#4885)
      [WiFi] Only connect using BSSID when BSSID is available
      [ESP32 WiFi] Fix reconnect issue after WIFI_REASON_AUTH_EXPIRE
      [FactoryReset] Store settings to keep in ESP32 NVS storage
      [Custom CDN] Move Custom CDN URL to config.dat
      [Custom CDN] Move position of where Custom CDN URL is stored in settings
      [Factory Reset] Use NVS stored defaults on reset
      [Custom CDN] Fix storing empty CDN url.
      [Factory Reset] Store WiFi/Eth config in NVS
      [Factory Reset] Store log/console settings in NVS
      [Custom CDN] Add checkbox to store Custom CDN to NVS
      [Custom.h] Update Custom-sample.h with new CUSTOM_BUILD_CDN_URL
      [Factory Reset] Add new flag to NVS for slow connect to hidden SSID
      [ESP8266 build] Set all ESP8266 'normal' builds to use CDN for CSS/JS
      automatically updated release notes for mega-20231130

Ton Huisman (68):
      [Lib] HeatpumpIR update to 1.0.23
      [Lib] HeatpumpIR Add compatibility with ESP32 Arduino 3.0/IDF 5.1.x
      [P023] Bugfix: Template parsing was overwriting the template
      [P159] Add LD2410 Radar presence detection
      [P023] Minor performance improvement
      [P159] Remove copy/paste evidence :-D
      [P159] Many improvements, add/update settings for sensitivity
      [P159] Fix compilation on LIMIT_BUILD_SIZE builds
      [P159] Small improvements
      [P159] Small improvements
      [P159] Add command for sensor factoryreset
      [Lib] LD2410: Fix bug (-1 for uint), add undocumented OutputPinState value
      [P159] Add OutputPinState option after AmbientLight option (breaking change!)
      [P159] Minor change to determine how that may influence the build
      [NEOPIXEL] Add NeoPixelBus_wrapper and implement in NeoPixel plugins
      [Lib] Adjust Adafruit_NeoMatrix to use NeoPixelBus_wrapper
      [ESP-IDF5.1] Update NeoPixelBus with Tasmota's patches for ESP-IDF5.1
      [NeoPixel] Add changelogs for applying NeoPixelBus_wrapper library
      [Build] Fix pygit2 version
      [Build] Fix pygit2 version
      [Build] Restore pygit2 version
      [Build] Try older/current version of pip
      [Build] Explicit version of libgit2
      [Build] Undo changes
      [ESP-IDF5.1] Fix build issue on older IDF based builds
      [Neopixel] Fixes and improvements
      [Build] Freeze pip dependencies
      [Build] Undo changes
      [Build] Try fix failing pygit2 install
      [Build] Try older Python version
      [Neopixel] Fix fall-through return value
      [Build] Fix some cherry-pick diffs
      [Build] Freeze Python to 3.11 to fix pygit2 build issue
      [P159] Add Gate0 energy values that where missing Add GetConfig support for fetching all available values Add ld2410,logall command for dumping all values in the log (INFO level) Code improvements
      [NeopixelWrapper] Code optimization
      [P021] Set Hysteresis value via config command
      [P021] Update documentation
      [Build] Freeze Python version to avoid build issue with pygit2
      [Build] Freeze Python version on 3.11 so pygit2 will run as intended
      [P021] Change commands SetHysteresis and GetHysteresis for consistency
      [Lib] LD2410: Read all data that can be read in 5 msec, add errorcount and data_valid checks
      [P159] Rework processing, now near-instant response Add GetConfig support for sensitivity per gate values
      [Lib] LD2410: Reformat source (nearly all is changed!) Replace yield() by delay(0)
      [P159] Fix wrong use of F(""), should be EMPTY_STRING
      [Lib] IRremoteESP8266 update to v2.8.6, with ESPEasy patches applied - Disable some (more) IR protocols to make 1M build fit - Add IDF 5.x compatibility
      [Lib] Adafruit_NeoMatrix: Fix includes
      [Lib] Remove Adafruit_NeoPixel from repo
      [P131] Fix variable initialization, call begin() to start the NeoPixels
      [P041] Uncrustify source, minor improvements
      [P042] Fix initializations to avoid crash at start, minor improvements
      [P070] Minor improvements
      [Lib] Update library.properties for local copy of Adafruit_NeoMatrix
      [Docs] Updates and corrections Nov. 2023
      [Docs] Updates and corrections Nov. 2023
      [P159] Add documentation
      [P159] Update EasyColorMirror
      [P159] Update comments to explicitly name LD2410
      [CDN] Set override url for CDN hosted files
      [CDN] Update documentation
      [CDN] Code improvements, Add to Provisioning
      [CDN] Update documentation
      [Provisioning] Split provisioning commands, add fallback for MAX builds, code cleanup
      [Provisioning] Update documentation
      [CDN] Replace system variables in url, update documentation
      [I2C] Add Device flag for 100 kHz-only devices
      [I2C] Devices that only support 100 kHz speed
      [Bugfix] [P159] Saving settings checkbox failed on ESP8266
      [Docs] Fix some typos Nov. 2023

jfmennedy (8):
      P093 Mitsubishi HeatPump Add Support for SetRemoteTemperature Resolves P093 - Mitsubishi Heat Pump Add Remote Temperature letscontrolit#4711
      Modify Changelog Order
      Help needed here
      - Fix float initialisaton, - Fix float comparator, - Still trying t get SetRemoteTemperature working...
      -Fix static const uint8_t RemoteTemperature
      - Implement remarks from review
      Documentation
      Documentation Review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Plugin Related to supported sensors Type: Enhancement Improve something already present
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

P093 Mitsubishi HeatPump jfmennedy/ESPEasy
P093 Mitsubishi HeatPump - Add Remote Temperature
3 participants
@TD-er @crnjan @jfmennedy