Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display last-applied-configuration annotation in detail-view #943

Merged
merged 1 commit into from
Sep 28, 2020
Merged

display last-applied-configuration annotation in detail-view #943

merged 1 commit into from
Sep 28, 2020

Conversation

0x7aF777
Copy link
Contributor

fix #719 display last-applied-configuration annotation in detail-view , but still filter it in search fields

Signed-off-by: Yangjun Wang yangjun.wang@wartsila.com

…ter it in search fields still

Signed-off-by: Yangjun Wang <yangjun.wang@wartsila.com>
Copy link
Contributor

@ixrock ixrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ixrock
Copy link
Contributor

ixrock commented Sep 22, 2020

@nevalla integration tests on Windows again failed, can't spot why.. any clue?
image

@Nokel81
Copy link
Collaborator

Nokel81 commented Sep 28, 2020

@ixrock not any more, shall we merge this?

@ixrock ixrock merged commit bc228c9 into lensapp:master Sep 28, 2020
@nevalla nevalla added the bug Something isn't working label Sep 29, 2020
@nevalla nevalla added this to the 3.6.5 milestone Sep 29, 2020
@nevalla nevalla mentioned this pull request Sep 30, 2020
@0x7aF777 0x7aF777 deleted the last-applied-configuration-detail-view branch October 10, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only single line annotations are shown in detailed view
4 participants