Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only single line annotations are shown in detailed view #719

Closed
gabrielbcn opened this issue Aug 20, 2020 · 3 comments · Fixed by #943
Closed

Only single line annotations are shown in detailed view #719

gabrielbcn opened this issue Aug 20, 2020 · 3 comments · Fixed by #943
Labels
area/ui bug Something isn't working
Milestone

Comments

@gabrielbcn
Copy link

Describe the bug
When getting details about an object, for instance deployments, daemon sets or services, the detail view will display only single line annotations and will ignore those that are multiline

To Reproduce
Steps to reproduce the behavior:

In the attached window capture you can see how a service that has two annotations is shown as having only one annotation, having the multi-line annotation (kubectl.kubernetes.io/last-applied-configuration) ignored.

Screen Shot 2020-08-20 at 11 50 43

Expected behavior
I expect either:

  • To display the full annotation in a foldable way, a multi-line annotation can take a lot of space and we don't want that
  • To get an indication that the annotation is there, maybe just the name equals three dots as I can always go to edit to see it

What I find misleading is that the annotation just "disappears". That can make me miss something important.

Screenshots
See above in explanation

Environment (please complete the following information):

  • Lens Version: 3.5.3
  • OS: OSX
  • Installation method: brew

Logs:
Not applicable

Kubeconfig:
Not applicable

Additional context
Not applicable

@nevalla nevalla added bug Something isn't working area/ui labels Aug 24, 2020
@nevalla nevalla added this to the 3.6.1 milestone Aug 24, 2020
@ixrock
Copy link
Contributor

ixrock commented Aug 29, 2020

I guess it's only kubectl.kubernetes.io/last-applied-configuration ignored in the output for some reason..
@nevalla maybe you remember why?

@gabrielbcn
Copy link
Author

Indeed, other multi-line annotations do work... I've just checked.

@nevalla
Copy link
Contributor

nevalla commented Sep 4, 2020

So, is the issue that last-applied-configuration is not visible in details drawer?

I guess it's only kubectl.kubernetes.io/last-applied-configuration ignored in the output for some reason..
@nevalla maybe you remember why?

Yes, it was bloating the details drawer back then. Is that something you really want to see on details, since it's something kubectl uses internally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants