Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding more integration tests #890

Merged
merged 2 commits into from
Sep 28, 2020

Conversation

jim-docker
Copy link
Contributor

@jim-docker jim-docker commented Sep 16, 2020

reorganized tests, added ability to skip cluster tests if minikube is not ready. To facilitate running tests locally, introduced TEST_NAMESPACE where test resources are created/manipulated so as not to clash with existing minikube resources

Signed-off-by: Jim Ehrismann jehrismann@mirantis.com

todo in subsequent PR:

  • figure out how to activate main menu items via spectron/WebDriverIO
  • introduce specific integration test selectors (new classes?)?
  • add more cluster operation tests

@jim-docker jim-docker force-pushed the more-integration-tests branch from 848e1be to e9a149a Compare September 18, 2020 19:39
@jim-docker jim-docker force-pushed the more-integration-tests branch 4 times, most recently from b1f19b7 to c06429d Compare September 24, 2020 03:04
@jim-docker jim-docker marked this pull request as ready for review September 24, 2020 03:17
@jim-docker
Copy link
Contributor Author

pod creation test is now failing on CI. Works locally, investigating

@jim-docker jim-docker requested a review from a team September 24, 2020 03:19
@jim-docker jim-docker force-pushed the more-integration-tests branch from c06429d to 127586a Compare September 24, 2020 03:24
reorganized tests, added ability to skip cluster tests if minikube is not ready
introduced INTEGRATION_TESTS namespace for sandboxing the cluster tests
added cluster page tests

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
@jim-docker jim-docker force-pushed the more-integration-tests branch from 127586a to cbbcdc7 Compare September 25, 2020 21:19
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
@jim-docker jim-docker force-pushed the more-integration-tests branch from cbbcdc7 to 254a45c Compare September 25, 2020 21:26
Copy link
Contributor

@jakolehm jakolehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakolehm jakolehm added area/tests enhancement New feature or request labels Sep 26, 2020
Copy link
Contributor

@nevalla nevalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim-docker jim-docker merged commit 6b231c9 into lensapp:master Sep 28, 2020
@nevalla nevalla mentioned this pull request Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants