Auto select one and only cluster from pasted config #888
Conversation
| @@ -54,8 +54,7 @@ | |||
|
|
|||
| form:not([novalidate]):invalid &[type=submit]:not(.active), | |||
| &:disabled { | |||
| color: silver; | |||
| background: $buttonDisabledBackground; | |||
| opacity: 50%; | |||
There was a problem hiding this comment.
is this Lens standard behaviour?
There was a problem hiding this comment.
Yes, most other disabled items change opacity.
|
This works for "Paste as target" but not for "Select kubeconfig file":
For drag-and-drop and file section by clicking the file folder the "Add cluster(s)" button remains disabled even though there is only one context in the kubeconfig. Or maybe that is intended... |
There was a problem hiding this comment.
LGTM except...this definitely gums up the integration tests, which open the drop-down and click on 'minikube'. Now it is probably deselecting 'minikube' and then trying to click the button, which will be grayed out.
Trying to run the tests locally makes it even worse, because it'll depend on how many contexts the user has in their config.
|
@jim-docker I just opened #917 to fix those tests |
- Disable add button with tooltip if no clusters are selected - Add functionality to tooltip to display correctly over disabled elements Signed-off-by: Sebastian Malton <smalton@mirantis.com>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
force-pushed
the
auto-select-first-cluster
branch
from
ba85658 to
35ab6ff
Compare
Signed-off-by: Sebastian Malton <sebastian@malton.name>
|
I have push a simplification to the |
elements
Signed-off-by: Sebastian Malton smalton@mirantis.com
fixes #850