Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workload 'kind' param to 'show-details' event #7464

Merged
merged 4 commits into from
Apr 4, 2023
+10 −2
Merged

Add workload 'kind' param to 'show-details' event #7464

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e2ced3b
Introduce getWorkloadKindFromUrl() method
aleksfront Apr 3, 2023
d8b62a1
Whitelist kind param to 'show-details' event
aleksfront Apr 3, 2023
b3477a4
Using parseKubeApi instead of new utility
aleksfront Apr 3, 2023
77e362f
Adding checks for empty selfLink
aleksfront Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...ges/core/src/features/telemetry/renderer/telemetry-white-list-for-functions.injectable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
*/
import { getInjectable } from "@ogre-tools/injectable";
import type { AppEvent } from "../../../common/app-event-bus/event-bus";
import { parseKubeApi } from "../../../common/k8s-api/kube-api-parse";

const navigateTo = [
"navigate-to-preference-tab-id",
Expand Down Expand Up @@ -91,7 +92,14 @@ const extensions = [

const externalActions = ["open-link-in-browser"];

const uiInteraction = ["show-details"];
const uiInteraction = [{
id: "show-details",
getParams: (selfLink: unknown) => {
return {
kind: parseKubeApi(selfLink as string).resource,
};
},
}];

const terminal = ["create-terminal-tab"];

Expand Down