Add workload 'kind' param to 'show-details' event #7464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
ixrock
reviewed
Apr 3, 2023
packages/core/src/features/telemetry/renderer/telemetry-white-list-for-functions.injectable.ts
Outdated
Show resolved
Hide resolved
ixrock
reviewed
Apr 3, 2023
packages/core/src/renderer/components/kube-detail-params/get-workload-kind-from-url.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
ixrock
previously approved these changes
Apr 3, 2023
packages/core/src/features/telemetry/renderer/telemetry-white-list-for-functions.injectable.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Nokel81
reviewed
Apr 3, 2023
|
|
||
| const terminal = ["create-terminal-tab"]; | ||
|
|
||
| export type WhiteListItem = | ||
| | string | ||
| | { id: string; getParams: (...args: unknown[]) => AppEvent["params"] }; | ||
| | { id: string; getParams: (...args: any[]) => AppEvent["params"] }; |
There was a problem hiding this comment.
technically unknown[] is more correct since the id could be wrong. But that is probably of low concern here. There are other improvements we could make in other places in the future.
ixrock
approved these changes
Apr 3, 2023
| return { | ||
| kind: parseKubeApi(selfLink as string).resource, | ||
| kind: selfLink ? parseKubeApi(selfLink).resource : "", |
There was a problem hiding this comment.
nit: What happens if selfLink exists but would be just incorrect? e.g. parseKubeApi("/404-error")?
I think parseKubeApi(selfLink)?.resource ?? "" would be more safe in this case, but probably not critical.
There was a problem hiding this comment.
In this case parseKubeApi throws an error and event fires with error field.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: showing details for Helm Charts and Releases are not affected. Sending custom events are necessary here.