Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop all extensions before quitting app #7450

Merged
merged 1 commit into from
Mar 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
/**
* Copyright (c) OpenLens Authors. All rights reserved.
* Licensed under MIT License. See LICENSE in root directory for more information.
*/
import { getInjectable } from "@ogre-tools/injectable";
import extensionInjectable from "../../../../extensions/extension-loader/extension/extension.injectable";
import extensionsInjectable from "../../../../extensions/extensions.injectable";

const stopAllExtensionsInjectable = getInjectable({
id: "stop-all-extensions",
instantiate: (di) => {
const extensionInstances = di.inject(extensionsInjectable);

return async () => {
for (const instance of extensionInstances.get()) {
const extension = di.inject(extensionInjectable, instance);

await instance.disable();
extension.deregister();
}
};
},
});

export default stopAllExtensionsInjectable;
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import clusterManagerInjectable from "./cluster/manager.injectable";
import loggerInjectable from "../common/logger.injectable";
import closeAllWindowsInjectable from "./start-main-application/lens-window/hide-all-windows/close-all-windows.injectable";
import emitAppEventInjectable from "../common/app-event-bus/emit-event.injectable";
import stopAllExtensionsInjectable from "../features/extensions/stopping/main/stop-all.injectable";

const stopServicesAndExitAppInjectable = getInjectable({
id: "stop-services-and-exit-app",
Expand All @@ -18,11 +19,13 @@ const stopServicesAndExitAppInjectable = getInjectable({
const logger = di.inject(loggerInjectable);
const closeAllWindows = di.inject(closeAllWindowsInjectable);
const emitAppEvent = di.inject(emitAppEventInjectable);
const stopAllExtensions = di.inject(stopAllExtensionsInjectable);

return () => {
return async () => {
emitAppEvent({ name: "service", action: "close" });
closeAllWindows();
clusterManager.stop();
await stopAllExtensions();
logger.info("SERVICE:QUIT");
setTimeout(exitApp, 1000);
};
Expand Down