Stop all extensions before quitting app #7450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
requested review from
Iku-turso and
jim-docker
and removed request for
a team
gabriel-mirantis
approved these changes
Mar 31, 2023
Nokel81
added a commit
that referenced
this pull request
Mar 31, 2023
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Merged
Nokel81
added a commit
that referenced
this pull request
Mar 31, 2023
* Stop all extensions before quitting app (#7450) Signed-off-by: Sebastian Malton <sebastian@malton.name> * Close Lens Proxy on quit of backend (#7453) - Extract global shared state of shell sessions Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix crash due to non base64 encoded secrets (#7448) * Fix crash due to non base64 encoded secrets Signed-off-by: Sebastian Malton <sebastian@malton.name> * Update snapshot Signed-off-by: Sebastian Malton <sebastian@malton.name> --------- Signed-off-by: Sebastian Malton <sebastian@malton.name> * Add temporal dependency to initializeExtensions (#7454) - So that extensions can ensure that the shell env is up to date Signed-off-by: Sebastian Malton <sebastian@malton.name> * Release 6.4.13 Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fixup cherry pick - 6.5 has @k8slens/utilities but 6.4 does not Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix cherry-pick due to files being moved between 6.4 and 6.5 Signed-off-by: Sebastian Malton <sebastian@malton.name> --------- Signed-off-by: Sebastian Malton <sebastian@malton.name>
jweak
pushed a commit
that referenced
this pull request
Apr 3, 2023
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Perhaps some extensions are holding onto resources which are causing the application to crash loudly. This should help stop that.