Simplify pages/menus/registry extension api internal implementation #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman <ixrock@gmail.com>
Signed-off-by: Roman <ixrock@gmail.com>
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
|
👍 It feels better now when not every extension have |
ixrock
suggested changes
Nov 13, 2020
ixrock
reviewed
Nov 13, 2020
ixrock
approved these changes
Nov 13, 2020
| @@ -20,12 +24,26 @@ export interface PageComponents { | |||
| Page: React.ComponentType<any>; | |||
| } | |||
|
|
|||
| const routePrefix = "/extension/:name" | |||
|
|
|||
| export function getPageUrl(ext: LensExtension, baseUrl = "") { | |||
There was a problem hiding this comment.
Suggested change
| export function getPageUrl(ext: LensExtension, baseUrl = "") { | |
| export function getPageRoute(ext: LensExtension, routePathOrUrl = "") { |
ixrock
reviewed
Nov 13, 2020
Merged
pauljwil
pushed a commit
to pauljwil/lens
that referenced
this pull request
Nov 13, 2020
Resolved conflicts while rebasing after pulling from remote Exit pipeline if extensions build or tests fail (lensapp#1370) Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com> Simplify pages/menus/registry extension api internal implementation (lensapp#1364) Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com> Co-authored-by: Roman <ixrock@gmail.com> Resolved conflicts in rebase from master Updated docs to sentence case throughout Changed mkdoc.yml nav to sentence case Signed-off-by: Paul Williams <pawilliams@mirantis.com> Changed headings to sentence case throughtout docs Signed-off-by: Paul Williams <pawilliams@mirantis.com> Changed all titles and headings back to title case throughout docs and in mkdocs.yml nav Signed-off-by: Paul Williams <pawilliams@mirantis.com> Updated docs to sentence case throughout Changed mkdoc.yml nav to sentence case Signed-off-by: Paul Williams <pawilliams@mirantis.com> Changed headings to sentence case throughtout docs Signed-off-by: Paul Williams <pawilliams@mirantis.com> Changed all titles and headings back to title case throughout docs and in mkdocs.yml nav Signed-off-by: Paul Williams <pawilliams@mirantis.com>
pauljwil
pushed a commit
to pauljwil/lens
that referenced
this pull request
Nov 13, 2020
Resolved conflicts while rebasing after pulling from remote Exit pipeline if extensions build or tests fail (lensapp#1370) Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com> Simplify pages/menus/registry extension api internal implementation (lensapp#1364) Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com> Co-authored-by: Roman <ixrock@gmail.com> Resolved conflicts in rebase from master Updated docs to sentence case throughout Changed mkdoc.yml nav to sentence case Signed-off-by: Paul Williams <pawilliams@mirantis.com> Changed headings to sentence case throughtout docs Signed-off-by: Paul Williams <pawilliams@mirantis.com> Changed all titles and headings back to title case throughout docs and in mkdocs.yml nav Signed-off-by: Paul Williams <pawilliams@mirantis.com> Updated docs to sentence case throughout Changed mkdoc.yml nav to sentence case Signed-off-by: Paul Williams <pawilliams@mirantis.com> Changed headings to sentence case throughtout docs Signed-off-by: Paul Williams <pawilliams@mirantis.com> Changed all titles and headings back to title case throughout docs and in mkdocs.yml nav Signed-off-by: Paul Williams <pawilliams@mirantis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies #1334
Includes fix from #1361.
Changes how relation between page and menu is done. Now each page is required to have
id, menu can target a page by providing atargetobject. Target can also be a page from another extension.