Fix: navigating to extension page

[ixrock]

Proper handling extension page base route.

Fixes:

• extension page route matches to actual extension name, e.g. /extension/lens-hello-world
• extension name updated in accordance to be supported in URL (@ removed, / => -)

Signed-off-by: Roman ixrock@gmail.com

[jim-docker]

Is there a uniqueness requirement for the name? This would have to be part of that because @foo would clash with one already named foo

[ixrock]

It won't clash since when package name with @ the format is @org/package-name, not just @some-name

[stefcameron]

I think we should be OK because I don't think @fred is a valid package name on NPM (and hopefully not on other registries like GH). You'd have to have a package name too, like @fred/fred, which would become fred-fred here, and wouldn't conflict with a package published as just fred (without a scope).

[jim-docker]

I can see it is unlikely but it's theoretically possible to have mirantis-foo and @mirantis/foo

[jakolehm]

What's the difference now between getPageUrl and getPageRoute? To me they look identical 🤔

[ixrock]

They are the same when no additional (suffix) route provided for the page:

export class PageRegistry<T extends PageRegistration> extends BaseRegistry<T> {
  getItems() {
    return super.getItems().map(item => {
      item.routePath = item.extension.getPageRoute(item.routePath)
      return item
    });
  }
}

[ixrock]

This is baseRoute of page-item, not baseRoute of extension.

[nevalla]

to me it looks like this.getPageUrl('foo') returns the same as this.getPageRoute('foo')

[ixrock]

Oh, now I see what you mean.. Both functions are similar but for different purposes..
Will refactor..

[ixrock]

@jakolehm PTAL, also fixed proper sub-pages route-paths and sub-menus urls.

[jim-docker]

tried it out with lens-extension-cc repo, LGTM

[stefcameron]

tried it out with lens-extension-cc repo, LGTM

Thanks for doing that, @jim-docker ! Glad to know it will work. 😄

[ixrock]

Closing in favour #1364