chore: disable compliance check #5185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kyranjamie
commented
Apr 9, 2024
•
kyranjamie
commented
pete-watters
approved these changes
Apr 9, 2024
alter-eggo
approved these changes
Apr 10, 2024
| @@ -15,6 +15,8 @@ const headers = { | |||
| Token: '51d3c7529eb08a8c62d41d70d006bdcd4248150fbd6826d5828ac908e7c12073', | |||
| }; | |||
|
|
|||
| export const isComplianceCheckEnabled = false; | |||
There was a problem hiding this comment.
shouldn't this be added to config?
There was a problem hiding this comment.
I think it should be the idea here is to quickly disable this for release and then re-enable afterwards so lets let it slide this time
pete-watters
force-pushed
the
chore/disable-compliance-check
branch
from
516e97d
to
5215ed3
Compare
| @@ -18,7 +18,7 @@ function mockChainalysisEntityCheckRequest(context: BrowserContext) { | |||
| ); | |||
| } | |||
|
|
|||
| test.describe('Compliance checks', () => { | |||
| test.skip('Compliance checks', () => { | |||
There was a problem hiding this comment.
@kyranjamie I checked #5122 and will just skip this whole test for now for release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.