Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: compliance checks #5122

Merged
merged 1 commit into from
Mar 28, 2024
Merged

feat: compliance checks #5122

merged 1 commit into from
Mar 28, 2024

Conversation

kyranjamie
Copy link
Collaborator

@kyranjamie kyranjamie commented Mar 26, 2024 •
edited by leather-bot
Loading

Try out Leather build 3664cd8 — Extension build, Test report, Storybook, Chromatic

@kyranjamie kyranjamie force-pushed the feat/compliance-checker branch 5 times, most recently from 9499696 to a10755c Compare March 27, 2024 16:37
@kyranjamie kyranjamie marked this pull request as ready for review March 27, 2024 16:38
@kyranjamie kyranjamie force-pushed the feat/compliance-checker branch 3 times, most recently from 22804b8 to 41242a9 Compare March 27, 2024 17:01
alter-eggo
alter-eggo approved these changes Mar 28, 2024
View reviewed changes
src/app/query/common/compliance-checker/compliance-checker.query.ts
return { ...entityReport, isOnSanctionsList: entityReport.risk === 'Severe' };
}

const oneWeekInMs = 604_800_000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe put this to some share/time.ts file?
we already have const weekInMs in src/app/query/bitcoin/ordinals/inscriptions-by-param.query.ts

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I'd like to use this library, it's 1kB and way nicer for readability https://github.com/vercel/ms

tests/specs/compliance-checks/compliance-checks.spec.ts Show resolved Hide resolved
@kyranjamie kyranjamie force-pushed the feat/compliance-checker branch 8 times, most recently from c63aee5 to 208a386 Compare March 28, 2024 12:34
@kyranjamie kyranjamie added this pull request to the merge queue Mar 28, 2024
Merged via the queue into dev with commit 6df0869 Mar 28, 2024
29 checks passed
@kyranjamie kyranjamie deleted the feat/compliance-checker branch March 28, 2024 12:51
@pete-watters pete-watters mentioned this pull request Apr 10, 2024
Merged
@kyranjamie kyranjamie mentioned this pull request Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbwoolf fbwoolf fbwoolf approved these changes

@alter-eggo alter-eggo alter-eggo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyranjamie @fbwoolf @alter-eggo