Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send users back into the onboarding state they left off on #294

Merged
merged 2 commits into from
Mar 12, 2020

Conversation

hstove
Copy link
Contributor

@hstove hstove commented Mar 12, 2020

How to QA this:

  • Use the demo app, start the onboarding process
  • Close the auth popup while you're on an onboarding screen
    • this can be "view secret key", "save secret key", or "username"
  • Back in the demo app, start onboarding again
    • You should go back to the page that you left off on
  • Finish auth - it should work as normal
  • Sign out of authenticator
  • Start onboarding flow again
    • ensure that you go through the flow from the start

@github-actions
Copy link
Contributor

Hey! If you'd like to test out the changes in this PR, check out our demo app. https://deploy-preview-294--authenticator-demo.netlify.com/

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2020

Size Change: 0 B

Total Size: 417 kB

ℹ️ View Unchanged
Filename Size Change
packages/connect/dist/bundle.js 355 kB 0 B
packages/connect/dist/connect.cjs.development.js 13.6 kB 0 B
packages/connect/dist/connect.cjs.production.min.js 10.5 kB 0 B
packages/connect/dist/connect.esm.js 13.5 kB 0 B
packages/connect/dist/connect.umd.development.js 13.8 kB 0 B
packages/connect/dist/connect.umd.production.min.js 10.6 kB 0 B
packages/connect/dist/index.js 143 B 0 B

compressed-size-action

Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't help but feel setOnboardingPath is clearer and easier to read than its alternative prepended with the word do.

Otherwise LGTM 👍🏼

@hstove hstove changed the base branch from fix/sign-in-redirect to master March 12, 2020 18:03
@hstove hstove force-pushed the feat/onboarding-continuation branch from c5d497c to 677451f Compare March 12, 2020 18:03
@hstove hstove merged commit 5ccda3c into master Mar 12, 2020
@hstove hstove deleted the feat/onboarding-continuation branch March 12, 2020 19:53
@timstackblock
Copy link
Contributor

This is working well

kyranjamie pushed a commit that referenced this pull request Oct 7, 2024
## [6.48.0](v6.47.1...v6.48.0) (2024-10-07)

### Features

* add inscription send flow testing, closes leather-io/issues[#191](#191) ([54fce3e](54fce3e))
* add option to hide balance, closes leather-io[#5096](#5096) ([32b064f](32b064f))
* bitflow implemenation, closes leather-io/issues[#99](#99) ([9c0a6e8](9c0a6e8))
* redesign connection flow, closes leather.io/issues[#283](#283) ([0717b12](0717b12))

### Bug Fixes

* **analytics:** initial route only used in report analytics ([a253390](a253390))
* broken styles ([cc6edb5](cc6edb5))
* edit network urls, closes leather-io/extension[#5795](#5795) ([7256379](7256379))
* path-to-regexp vulnerability GHSA-9wv6-86v2-598j ([36a84dc](36a84dc))
* refactor add network to use card footer, closes leather-io/issues[#313](#313) ([68de602](68de602))
* secret key stored cleartext in memory ([e0bdec9](e0bdec9))
* security audit failures ([d4c8b48](d4c8b48))
* show transaction amount above Increase Fee, closes [#5826](#5826) ([0a61651](0a61651))
* storybook icons, closes leather-io/issues[#294](#294) ([a0b30eb](a0b30eb))
* update manifest description, closes leather-io/issues[#310](#310) ([3450e0a](3450e0a))

### Internal

* blockchain model ([6bbb1fa](6bbb1fa))
* currency model imports ([54e2865](54e2865))
* pin node < v22 ([27f3b67](27f3b67))
* post-release merge back ([2b6bc91](2b6bc91))
* remove brc20 send flow code ([ad2d69f](ad2d69f))
* update wbip004 method name, closes [#5866](#5866) ([d0873e8](d0873e8))
* update webpack ([da58aa7](da58aa7))
* upgrade pnpm ([fb5a46f](fb5a46f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants