Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update method name in WBIP004 discovery array object to match Leather API #5866

Closed
alexp3y opened this issue Sep 20, 2024 · 0 comments · Fixed by #5867
Closed

Update method name in WBIP004 discovery array object to match Leather API #5866

alexp3y opened this issue Sep 20, 2024 · 0 comments · Fixed by #5867
Assignees
@alexp3y
Labels
area:api needs:refactoring Tech debt, developer experience, testing, etc.

Comments

@alexp3y
Copy link
Contributor

alexp3y commented Sep 20, 2024

Small change needed to the WBIP004 provider discovery array object to update the send transfer method name to match the Leather API spec.

Currently registered as "sentTransfer". Should be "sendTransfer".
@alexp3y alexp3y added needs:refactoring Tech debt, developer experience, testing, etc. area:api labels Sep 20, 2024
@alexp3y alexp3y self-assigned this Sep 20, 2024
alexp3y added a commit that referenced this issue Sep 20, 2024
@alexp3y
refactor: update wbip004 method name, closes #5866
1d84ce2
alexp3y added a commit that referenced this issue Sep 20, 2024
@alexp3y
refactor: update wbip004 method name, closes #5866
f7aa920
@alexp3y alexp3y linked a pull request Sep 20, 2024 that will close this issue
refactor: update wbip004 method name, closes #5866 #5867
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 20, 2024
@alexp3y
refactor: update wbip004 method name, closes #5866
d0873e8
alexp3y added a commit that referenced this issue Sep 25, 2024
@alexp3y
refactor: update wbip004 method name, closes #5866
cf8b942
kyranjamie pushed a commit that referenced this issue Oct 7, 2024
@semantic-release-bot
chore(release): 6.48.0
24425d1 
## [6.48.0](v6.47.1...v6.48.0) (2024-10-07)

### Features

* add inscription send flow testing, closes leather-io/issues[#191](#191) ([54fce3e](54fce3e))
* add option to hide balance, closes leather-io[#5096](#5096) ([32b064f](32b064f))
* bitflow implemenation, closes leather-io/issues[#99](#99) ([9c0a6e8](9c0a6e8))
* redesign connection flow, closes leather.io/issues[#283](#283) ([0717b12](0717b12))

### Bug Fixes

* **analytics:** initial route only used in report analytics ([a253390](a253390))
* broken styles ([cc6edb5](cc6edb5))
* edit network urls, closes leather-io/extension[#5795](#5795) ([7256379](7256379))
* path-to-regexp vulnerability GHSA-9wv6-86v2-598j ([36a84dc](36a84dc))
* refactor add network to use card footer, closes leather-io/issues[#313](#313) ([68de602](68de602))
* secret key stored cleartext in memory ([e0bdec9](e0bdec9))
* security audit failures ([d4c8b48](d4c8b48))
* show transaction amount above Increase Fee, closes [#5826](#5826) ([0a61651](0a61651))
* storybook icons, closes leather-io/issues[#294](#294) ([a0b30eb](a0b30eb))
* update manifest description, closes leather-io/issues[#310](#310) ([3450e0a](3450e0a))

### Internal

* blockchain model ([6bbb1fa](6bbb1fa))
* currency model imports ([54e2865](54e2865))
* pin node < v22 ([27f3b67](27f3b67))
* post-release merge back ([2b6bc91](2b6bc91))
* remove brc20 send flow code ([ad2d69f](ad2d69f))
* update wbip004 method name, closes [#5866](#5866) ([d0873e8](d0873e8))
* update webpack ([da58aa7](da58aa7))
* upgrade pnpm ([fb5a46f](fb5a46f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexp3y alexp3y

Labels
area:api needs:refactoring Tech debt, developer experience, testing, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: update wbip004 method name, closes #5866 leather-io/extension
1 participant
@alexp3y