-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ledger routing issue when rejecting #5143
Labels
area:ledger
bug
Functionality broken
bug-p3
Non-critical functionality broken for many users, or there are clear workarounds
effort:medium
Expected to take 2-5 days of integration work
Milestone
Comments
kyranjamie
added
bug
Functionality broken
bug-p3
Non-critical functionality broken for many users, or there are clear workarounds
area:ledger
labels
Mar 28, 2024
pete-watters
added a commit
that referenced
this issue
Apr 12, 2024
pete-watters
added a commit
that referenced
this issue
Apr 12, 2024
pete-watters
added a commit
that referenced
this issue
Apr 16, 2024
pete-watters
added
the
effort:medium
Expected to take 2-5 days of integration work
label
Apr 19, 2024
pete-watters
added a commit
that referenced
this issue
Apr 25, 2024
pete-watters
added a commit
that referenced
this issue
May 7, 2024
pete-watters
added a commit
that referenced
this issue
May 7, 2024
pete-watters
added a commit
that referenced
this issue
May 7, 2024
pete-watters
added a commit
that referenced
this issue
May 9, 2024
I have come up with a fix here where we determine where to go back based on the initial path of the current route. This is similar to what I tried to change the routing to remove |
github-merge-queue bot
pushed a commit
that referenced
this issue
May 15, 2024
…edger actions, closes #5143
pete-watters
added a commit
that referenced
this issue
May 15, 2024
kyranjamie
pushed a commit
that referenced
this issue
May 17, 2024
## [6.40.0](v6.39.0...v6.40.0) (2024-05-17) ### Features * add link in swaps disabled tooltip ([93f8964](93f8964)) * enable btc retrieval, closes [#5067](#5067) ([92d9603](92d9603)) ### Bug Fixes * brc20 sends software only ([4983476](4983476)) * go back properly and don't allow user to close non cancellable ledger actions, closes [#5143](#5143) ([c28342b](c28342b)) * **ledger:** use correct key number ([56100bf](56100bf)) * only decorate psbt inputs without an existing nonWitnessUtxo ([d47f87b](d47f87b)) * show correct amount for nonWitnessUtxo, ref [#5113](#5113) ([65a4f52](65a4f52)) * show correct UI count for BTC addresses being pulled, ref [#4983](#4983) ([9f73b24](9f73b24)) * utxos and transaction request cancellation, closes [#5058](#5058) ([ae1b04b](ae1b04b)) ### Internal * add backgroundLocation for device busy step ([e288d41](e288d41)) * assets and asset list ([88939cc](88939cc)) * btc balance ([bbc43d6](bbc43d6)) * post-release merge back ([61b8171](61b8171)) * refactor canclose ([d275ad7](d275ad7)) * stx balance ([4e3190f](4e3190f)) * temporarily disable swaps feature ([e34d5f3](e34d5f3)) * update packages ([c685b10](c685b10))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:ledger
bug
Functionality broken
bug-p3
Non-critical functionality broken for many users, or there are clear workarounds
effort:medium
Expected to take 2-5 days of integration work
When rejecting an action, and pressing the
×
button, the user is navigated to the homepage, rather than to the beginning of the signing flow.This bug is likely caused by the
/*
routing used, breaking thenavigate('..')
action.2024-03-28-000149.mp4
The text was updated successfully, but these errors were encountered: