Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ledger routing issue when rejecting #5143

Closed
kyranjamie opened this issue Mar 28, 2024 · 1 comment · Fixed by #5353
Closed

Ledger routing issue when rejecting #5143

kyranjamie opened this issue Mar 28, 2024 · 1 comment · Fixed by #5353
Assignees
@pete-watters
Labels
area:ledger bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds effort:medium Expected to take 2-5 days of integration work
Milestone
Fix urgent bugs

Comments

@kyranjamie
Copy link
Collaborator

When rejecting an action, and pressing the × button, the user is navigated to the homepage, rather than to the beginning of the signing flow.

This bug is likely caused by the /* routing used, breaking the navigate('..') action.

2024-03-28-000149.mp4
@kyranjamie kyranjamie added bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds area:ledger labels Mar 28, 2024
pete-watters added a commit that referenced this issue Apr 12, 2024
@pete-watters
fix: don't allow user to close non cancellable ledger actions, closes #…
c7f8485 
…5143
pete-watters added a commit that referenced this issue Apr 12, 2024
@pete-watters
fix: don't allow user to close non cancellable ledger actions, closes #…
32eba94 
…5143
@pete-watters pete-watters mentioned this issue Apr 15, 2024
Closed
pete-watters added a commit that referenced this issue Apr 16, 2024
@pete-watters
fix: don't allow user to close non cancellable ledger actions, closes #…
914de06 
…5143
@pete-watters pete-watters added the effort:medium Expected to take 2-5 days of integration work label Apr 19, 2024
pete-watters added a commit that referenced this issue Apr 25, 2024
@pete-watters
fix: don't allow user to close non cancellable ledger actions, closes #…
1b6d833 
…5143
@pete-watters pete-watters added this to the Fix urgent bugs milestone May 1, 2024
pete-watters added a commit that referenced this issue May 7, 2024
@pete-watters
fix: don't allow user to close non cancellable ledger actions, closes #…
9eba5da 
…5143
pete-watters added a commit that referenced this issue May 7, 2024
@pete-watters
fix: don't allow user to close non cancellable ledger actions, closes #…
d9d1ca1 
…5143
pete-watters added a commit that referenced this issue May 7, 2024
@pete-watters
fix: don't allow user to close non cancellable ledger actions, closes #…
151164d 
…5143
pete-watters added a commit that referenced this issue May 9, 2024
@pete-watters
fix: don't allow user to close non cancellable ledger actions, closes #…
a50a550 
…5143
pete-watters added a commit that referenced this issue May 9, 2024
@pete-watters
fix: go back properly and don't allow user to close non cancellable l…
30976bc 
…edger actions, closes #5143
pete-watters added a commit that referenced this issue May 9, 2024
@pete-watters
fix: go back properly and don't allow user to close non cancellable l…
77704f9 
…edger actions, closes #5143
pete-watters added a commit that referenced this issue May 9, 2024
@pete-watters
fix: go back properly and don't allow user to close non cancellable l…
f28b981 
…edger actions, closes #5143
@pete-watters pete-watters mentioned this issue May 9, 2024
Merged
pete-watters added a commit that referenced this issue May 9, 2024
@pete-watters
fix: go back properly and don't allow user to close non cancellable l…
85328a9 
…edger actions, closes #5143
@pete-watters
Copy link
Contributor

I have come up with a fix here where we determine where to go back based on the initial path of the current route. This is similar to what ../ was doing.

I tried to change the routing to remove /* which I agree is likely breaking the ../ navigation but couldn't get it to work without causing more problems.

pete-watters added a commit that referenced this issue May 13, 2024
@pete-watters
fix: go back properly and don't allow user to close non cancellable l…
e2c7e19 
…edger actions, closes #5143
@markmhendrickson markmhendrickson linked a pull request May 13, 2024 that will close this issue
fix: Ledger - cancel properly and don't allow user to close non cancellable sections #5353
Merged
pete-watters added a commit that referenced this issue May 14, 2024
@pete-watters
fix: go back properly and don't allow user to close non cancellable l…
05f5588 
…edger actions, closes #5143
pete-watters added a commit that referenced this issue May 15, 2024
@pete-watters
fix: go back properly and don't allow user to close non cancellable l…
89257f3 
…edger actions, closes #5143
github-merge-queue bot pushed a commit that referenced this issue May 15, 2024
@pete-watters
fix: go back properly and don't allow user to close non cancellable l…
c28342b 
…edger actions, closes #5143
pete-watters added a commit that referenced this issue May 15, 2024
@pete-watters
chore: add defensive code and better analytics for broadcast errors, …
997aa53 
…ref #5143
@pete-watters pete-watters mentioned this issue May 15, 2024
Merged
kyranjamie pushed a commit that referenced this issue May 17, 2024
@semantic-release-bot
chore(release): 6.40.0
d9894a4 
## [6.40.0](v6.39.0...v6.40.0) (2024-05-17)

### Features

* add link in swaps disabled tooltip ([93f8964](93f8964))
* enable btc retrieval, closes [#5067](#5067) ([92d9603](92d9603))

### Bug Fixes

* brc20 sends software only ([4983476](4983476))
* go back properly and don't allow user to close non cancellable ledger actions, closes [#5143](#5143) ([c28342b](c28342b))
* **ledger:** use correct key number ([56100bf](56100bf))
* only decorate psbt inputs without an existing nonWitnessUtxo ([d47f87b](d47f87b))
* show correct amount for nonWitnessUtxo, ref [#5113](#5113) ([65a4f52](65a4f52))
* show correct UI count for BTC addresses being pulled, ref [#4983](#4983) ([9f73b24](9f73b24))
* utxos and transaction request cancellation, closes [#5058](#5058) ([ae1b04b](ae1b04b))

### Internal

* add backgroundLocation for device busy step ([e288d41](e288d41))
* assets and asset list ([88939cc](88939cc))
* btc balance ([bbc43d6](bbc43d6))
* post-release merge back ([61b8171](61b8171))
* refactor canclose ([d275ad7](d275ad7))
* stx balance ([4e3190f](4e3190f))
* temporarily disable swaps feature ([e34d5f3](e34d5f3))
* update packages ([c685b10](c685b10))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pete-watters pete-watters

Labels
area:ledger bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds effort:medium Expected to take 2-5 days of integration work
Projects
None yet
Milestone
Fix urgent bugs
2 participants
@kyranjamie @pete-watters