Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce retrieving uninscribed BTC from taproot (inscription) address #5067

Closed
314159265359879 opened this issue Mar 13, 2024 · 3 comments
Closed

Reintroduce retrieving uninscribed BTC from taproot (inscription) address #5067

314159265359879 opened this issue Mar 13, 2024 · 3 comments
Assignees
@alter-eggo
Labels
effort:medium Expected to take 2-5 days of integration work enhancement enhancement-p2 Critical functionality needed by few users, with no clear alternatives

Comments

@314159265359879
Copy link
Contributor

Reasons this was disabled:

  1. Sometimes it would display sats erronously as uninscribed due to API connection issue
  2. Or due to the sats still pending incoming
  3. Or due to the indexer not yet having processed the state

We believe the API is now more reliable because there are two checks, filtering UTXO with inscriptions for displaying and again when assessing available balance for sending. Did I understand this correctly @alter-eggo?

To prevent issues due to 2-3 in addition we could do the following:
A. Never display UTXO's with a size of 10000 sats or less as uninscribed. Inscriptions are often in small UTXO's that are often not even worth retrieving.
B. And/or do not display them until they have 6-12 confirmations (ca. 1-2 hours) something central exchanges do to avoid issues associated with reorgs/double spending.

Related
#4513
@314159265359879 314159265359879 added enhancement-p2 Critical functionality needed by few users, with no clear alternatives enhancement labels Mar 13, 2024
@markmhendrickson
Copy link
Collaborator

markmhendrickson commented Apr 17, 2024 •
edited
Loading

We believe the API is now more reliable because there are two checks, filtering UTXO with inscriptions for displaying and again when assessing available balance for sending.

@alter-eggo is this correct?

And @kyranjamie remind me – is this why we disabled this feature in the first place (because there was a delay sometimes in the API recognizing recently deposited inscriptions, leading to their possible expenditure as as fees during retrieval)?

To prevent issues due to 2-3 in addition we could do the following:
A. Never display UTXO's with a size of 10000 sats or less as uninscribed. Inscriptions are often in small UTXO's that are often not even worth retrieving.
B. And/or do not display them until they have 6-12 confirmations (ca. 1-2 hours) something central exchanges do to avoid issues associated with reorgs/double spending.

How difficult would either of these solutions be technically?

@alter-eggo
Copy link
Contributor

@314159265359879 @markmhendrickson yeah, we filter utxos with request to hiro and then check utxos when broadcasting with request to ordinals.com

@alter-eggo
Copy link
Contributor

@markmhendrickson I believe both are quite easy to implement

@alter-eggo alter-eggo added the effort:medium Expected to take 2-5 days of integration work label May 1, 2024
alter-eggo added a commit that referenced this issue May 14, 2024
@alter-eggo
feat: enable btc retrieval, closes #5067
58b1bd8
alter-eggo added a commit that referenced this issue May 14, 2024
@alter-eggo
feat: enable btc retrieval, closes #5067
68795d1
github-merge-queue bot pushed a commit that referenced this issue May 14, 2024
@alter-eggo
feat: enable btc retrieval, closes #5067
92d9603
@alter-eggo alter-eggo mentioned this issue May 17, 2024
Merged
kyranjamie pushed a commit that referenced this issue May 17, 2024
@semantic-release-bot
chore(release): 6.40.0
d9894a4 
## [6.40.0](v6.39.0...v6.40.0) (2024-05-17)

### Features

* add link in swaps disabled tooltip ([93f8964](93f8964))
* enable btc retrieval, closes [#5067](#5067) ([92d9603](92d9603))

### Bug Fixes

* brc20 sends software only ([4983476](4983476))
* go back properly and don't allow user to close non cancellable ledger actions, closes [#5143](#5143) ([c28342b](c28342b))
* **ledger:** use correct key number ([56100bf](56100bf))
* only decorate psbt inputs without an existing nonWitnessUtxo ([d47f87b](d47f87b))
* show correct amount for nonWitnessUtxo, ref [#5113](#5113) ([65a4f52](65a4f52))
* show correct UI count for BTC addresses being pulled, ref [#4983](#4983) ([9f73b24](9f73b24))
* utxos and transaction request cancellation, closes [#5058](#5058) ([ae1b04b](ae1b04b))

### Internal

* add backgroundLocation for device busy step ([e288d41](e288d41))
* assets and asset list ([88939cc](88939cc))
* btc balance ([bbc43d6](bbc43d6))
* post-release merge back ([61b8171](61b8171))
* refactor canclose ([d275ad7](d275ad7))
* stx balance ([4e3190f](4e3190f))
* temporarily disable swaps feature ([e34d5f3](e34d5f3))
* update packages ([c685b10](c685b10))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alter-eggo alter-eggo

Labels
effort:medium Expected to take 2-5 days of integration work enhancement enhancement-p2 Critical functionality needed by few users, with no clear alternatives
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@markmhendrickson @314159265359879 @alter-eggo