-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce retrieving uninscribed BTC from taproot (inscription) address #5067
Comments
@alter-eggo is this correct? And @kyranjamie remind me – is this why we disabled this feature in the first place (because there was a delay sometimes in the API recognizing recently deposited inscriptions, leading to their possible expenditure as as fees during retrieval)?
How difficult would either of these solutions be technically? |
@314159265359879 @markmhendrickson yeah, we filter utxos with request to hiro and then check utxos when broadcasting with request to ordinals.com |
@markmhendrickson I believe both are quite easy to implement |
## [6.40.0](v6.39.0...v6.40.0) (2024-05-17) ### Features * add link in swaps disabled tooltip ([93f8964](93f8964)) * enable btc retrieval, closes [#5067](#5067) ([92d9603](92d9603)) ### Bug Fixes * brc20 sends software only ([4983476](4983476)) * go back properly and don't allow user to close non cancellable ledger actions, closes [#5143](#5143) ([c28342b](c28342b)) * **ledger:** use correct key number ([56100bf](56100bf)) * only decorate psbt inputs without an existing nonWitnessUtxo ([d47f87b](d47f87b)) * show correct amount for nonWitnessUtxo, ref [#5113](#5113) ([65a4f52](65a4f52)) * show correct UI count for BTC addresses being pulled, ref [#4983](#4983) ([9f73b24](9f73b24)) * utxos and transaction request cancellation, closes [#5058](#5058) ([ae1b04b](ae1b04b)) ### Internal * add backgroundLocation for device busy step ([e288d41](e288d41)) * assets and asset list ([88939cc](88939cc)) * btc balance ([bbc43d6](bbc43d6)) * post-release merge back ([61b8171](61b8171)) * refactor canclose ([d275ad7](d275ad7)) * stx balance ([4e3190f](4e3190f)) * temporarily disable swaps feature ([e34d5f3](e34d5f3)) * update packages ([c685b10](c685b10))
Reasons this was disabled:
We believe the API is now more reliable because there are two checks, filtering UTXO with inscriptions for displaying and again when assessing available balance for sending. Did I understand this correctly @alter-eggo?
To prevent issues due to 2-3 in addition we could do the following:
A. Never display UTXO's with a size of 10000 sats or less as uninscribed. Inscriptions are often in small UTXO's that are often not even worth retrieving.
B. And/or do not display them until they have 6-12 confirmations (ca. 1-2 hours) something central exchanges do to avoid issues associated with reorgs/double spending.
Related
#4513
The text was updated successfully, but these errors were encountered: