Remove hover effect for BRC-20 tokens under balances

[markmhendrickson]

They shouldn't have any hover effect, like the other token types don't:

[pete-watters]

I checked this and we show a hover on this element as it's wrapped in another tooltip element that shows when we don't have enough BTC in balance.

I am forcing it to show below now:

@markmhendrickson - should this tooltip show on the home page balances? Or should it be in other flows when choosing BRC20. e.g. on Send ?

We have a lot of almost identical code sharing components but in different flows. Its related to this also #4949 where we show BRC-20 under the fund flow

My thoughts are that:

• this tooltip is only supposed to show on the Send flow where you can click BRC-20 then go to send
• BRC-20 should not appear at all on fund flow
• On the home assets page we never show a tooltip or click ability for this

Area.mp4

[markmhendrickson]

Those thoughts are indeed correct.

I'm not even sure we should show this tooltip within the send flow (when picking the token for send), since it seems like we could handle better through some other UX pattern. But we can tackle that later during send UX redesign so it's okay to leave it there (while removing from home) for now – or just remove from both if easier. cc @fabric-8

[pete-watters]

Thanks @markmhendrickson 👍

It feels confusing how this was working:

• If you don't have funds the row showed hover but you can't click
• on hover it gave the tooltip warning

I went with removing the tooltip as it was faster and more effective for now. I kept having the row disabled on 0 balance as I don't want it to cause another issue like the form crashing.

Lets think of how to improve it later. My gut says we should let people go to BRC-20 send form and then have form validation there if they don't have enough balance for fees.

Right now the check we had is to let them progress if they have a BTC balance greater than 0, which is not really accurate as they still might not have enough to cover fees:

  const hasPositiveBtcBalanceForFees =
    btcCryptoCurrencyAssetBalance.balance.amount.isGreaterThan(0);

We use a similar check in PendingBrcTransfer so we can consider our preferred flow and improve both together.

[pete-watters]

I included a fix for this in #4655, I can't link anymore issues to that PR as the max is 10.

[pete-watters]

This has been release