Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove display of unsuppported tokens from token picker for buy flow #4949

Closed
markmhendrickson opened this issue Feb 16, 2024 · 2 comments
Closed

Remove display of unsuppported tokens from token picker for buy flow #4949

markmhendrickson opened this issue Feb 16, 2024 · 2 comments
Assignees
@pete-watters
Labels
bug-p3 Non-critical functionality broken for many users, or there are clear workarounds
Milestone
Fix urgent bugs

Comments

@markmhendrickson
Copy link
Collaborator

It appears that our reuse of the token picker here has allowed BRC-20 tokens to display in the buy flow inadvertently when only BTC and STX should appear:

Image
@markmhendrickson markmhendrickson added this to the Fix urgent bugs milestone Feb 16, 2024
@markmhendrickson markmhendrickson added the bug-p3 Non-critical functionality broken for many users, or there are clear workarounds label Mar 12, 2024
@pete-watters pete-watters self-assigned this Mar 12, 2024
@markmhendrickson markmhendrickson changed the title Fix display of unsuppported tokens from token picker for buy flow Remove display of unsuppported tokens from token picker for buy flow Mar 13, 2024
@pete-watters pete-watters mentioned this issue Mar 21, 2024
Closed
@pete-watters
Copy link
Contributor

Closing this to fix in #5071 as it seems related to incorrect usage of shared BRC-20 components.

pete-watters added a commit that referenced this issue Mar 21, 2024
@pete-watters
chore: only show relevant fund assets and deprecate tooltip for send …
990ee0e 
…BRC-20, ref #5071 #4949
@pete-watters
Copy link
Contributor

I included a fix for this in #4655, I can't link anymore issues to that PR as the max is 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pete-watters pete-watters

Labels
bug-p3 Non-critical functionality broken for many users, or there are clear workarounds
Projects
None yet
Milestone
Fix urgent bugs
Development

No branches or pull requests
3 participants
@markmhendrickson @pete-watters @edgarkhanzadian