Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve corejs3-shipped-proposals build issues. #4398

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Resolve corejs3-shipped-proposals build issues. #4398

merged 1 commit into from
Jun 17, 2020

Conversation

JoshStrobl
Copy link
Contributor

@babel/compat-data 7.8.6 to pre-7.10 series has compilation issues with newer node 12.x and 13.x releases.

PR Checklist

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Using 7.8.6 will cause the failure to find the module '@babel/compat-data/corejs3-shipped-proposals', causing build failures on systems with those node releases (e.g. Solus).

This patch bumps @babel/preset-env, @babel/preset-flow, @babel/preset-react, and their deps specifically to newer releases to resolve compilation. Please note that this does not update all of babel to newer 7.10 series releases, just specifically resolves compilation on specific Linux platforms. Should LBRY folks want to upgrade fully to newer 7.10 series, that's probably something worth doing separately. At least during my short analysis there didn't appear to be any breaking changes.

This is already in use and validated via Solus: https://dev.getsol.us/R3654:1675cd3bb40d7d2f36483c9ebc5c0060ce3fe9f6

What is the current behavior?

Build failures under nodejs 12.18.0 on Solus

What is the new behavior?

Build success under nodejs 12.18.0 on Solus

Other information

Issues in other projects:

@babel/compat-data 7.8.6 to pre-7.10 series has compilation issues with newer node 12.x and 13.x releases. Using 7.8.6 will cause the failure to find the module `'@babel/compat-data/corejs3-shipped-proposals'`, causing build failures on systems with those node releases (e.g. Solus).

This patch bumps @babel/preset-env, @babel/preset-flow, and @babel/preset-react specifically to newer releases to resolve compilation. Please note that this does not update all of babel to newer 7.10 series releases, just specifically resolves compilation on specific Linux platforms.
@kauffj
Copy link
Member

kauffj commented Jun 16, 2020

"At least during my short analysis there didn't appear to be any breaking changes."

That's code for ship it.

(I just came here to make that joke. Please be responsible, and thanks as always @JoshStrobl!)

@neb-b neb-b merged commit a479c70 into lbryio:master Jun 17, 2020
@neb-b
Copy link

neb-b commented Jun 17, 2020

Thanks for opening this @JoshStrobl

Were you seeing this in the released app? Or just in dev?

@JoshStrobl
Copy link
Contributor Author

@seanyesmunt I was seeing this with the 0.46.2 production release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants