CNS-140,CNS-150: dockerize lavad build and execution #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
orenl-lava
force-pushed
the
CNS-150-dockerize-lavad-build
branch
5 times, most recently
from
e70ae4e to
426ed5e
Compare
orenl-lava
changed the title
orenl-lava
changed the title
Update the Makefile and intorduce Dockerfile to improve lavad build. Notable make targets (for all targets - see Makefile): make build - local build (output in ./build/) make test - run unit-tests make lint - run the linter make docker-build - local build with docker image (host arch) make build-images - build and produce docker images (all archs) make build-image-amd64 - build and produce docker image (linux/amd64) make build-image-amd64 - build and produce docker image (linux/arm64) Other notable changes: - See Makefile for options to turn on/off via LAVA_BUILD_OPTIONS variable - Use LAVA_BUILD_OPTIONS="static" to build static binary - Use LAVA_BUILD_OPTIONS="static,release" to build static binary for release Also updated .dockerignore (notably, added .git/ to avoid the cost). Anyway, the copy only affects the builder stage in docker - nothing is copied to the final image. Also updates .gitignote (primarily some cleanup).
orenl-lava
force-pushed
the
CNS-150-dockerize-lavad-build
branch
from
426ed5e to
5a48ecc
Compare
Update the Dockerfile to generate docker image that can run lava node.
(Implemented using the artifacts in docker/ directory.)
To start a lava node in a container, run the command:
docker-compose --profile node --env-file env -f docker/docker-compose.yml up
Edit the file `env` to adjust the (external) ports used by this node (see that
file for the defaults).
It will execute the script `start_node.sh` (from docker/), which follows
the instructions for starting a node (with cosmovisor).
orenl-lava
force-pushed
the
CNS-150-dockerize-lavad-build
branch
from
5a48ecc to
62cd4c3
Compare
SeanZoR
reviewed
Jan 18, 2023
SeanZoR
suggested changes
Jan 18, 2023
SeanZoR
previously approved these changes
Jan 18, 2023
Update the Dockerfile to generate docker image that can run lava portal.
(Implemented using the artifacts in docker/ directory.)
To start a lava portal in a container, run the command:
docker-compose --profile portal --env-file env -f docker/docker-compose.yml up
Edit the file `env` to adjust the portal parameters used by this portal (see that
file for the defaults).
It will execute the script `start_portal.sh` (from docker/), which follows
the instructions for starting a portal. If needed, it will also do stake-client
(including if the stake amount is to be raised).
Propagete LAVA_BUILD_OPTIONS env var and GIT_CLONE build-arg to the docker build. This ensures that the build in docker indeeds generates the release. Also allow user to select release version using LAVA_VERSION env variable. Add examples in the Makefile for how to run.
Fix use of LAVA_BULID_OPTIONS in Dockerfile's call to 'make'. Build cosmovisor independent of the builder stage (image). Document the env variables of the Makefile, and unused options.
Update the Dockerfile to generate docker image that can run lava provider.
(Implemented using the artifacts in docker/ directory.)
To start a lava provider in a container, run the command:
docker-compose --profile provider \
--env-file docker/env -f docker/docker-compose.yml up
Edit the file `env` to adjust the portal parameters used by this provider (see
that file for the defaults).
It will execute the script `start_provider.sh` (from docker/), which follows
the instructions for starting a provider. If needed, it will also execute the
stake-provider (including if the stake amount is to be raised).
orenl-lava
force-pushed
the
CNS-150-dockerize-lavad-build
branch
from
cdd83f2 to
6457a99
Compare
praveenperera
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Makefile and intorduce Dockerfile to improve lavad build.
Notable make targets (for all targets - see Makefile):
make build - local build (output in ./build/)
make test - run unit-tests
make lint - run the linter
make docker-build - local build with docker image (host arch)
make build-images - build and produce docker images (all archs)
make build-image-amd64 - build and produce docker image (linux/amd64)
make build-image-amd64 - build and produce docker image (linux/arm64)
Other notable changes:
Also updated .dockerignore (notably, added .git/ to avoid the cost). Anyway, the copy only affects the builder stage in docker - nothing is copied to the final image.
Also updates .gitignote (primarily some cleanup).
What kind of change does this PR introduce? (Bug fix, feature, unit tests, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Please describe what manual tests you ran, if applicable
Other information: