CNS 158 makefile abort on version mismatch with the actual code #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 5, 2023 18:23
Make sure that the specified VERSION matches that of the current checked-out code, and that the code is clean (i.e. no uncommitted changes, and no extra commits beyond the recent tag).
orenl-lava
changed the title
ranlavanet
requested review from
ranlavanet and
Yaroms
and removed request for
ranlavanet
|
Superseded by PR #235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
The Makefile is used to generate production versions. It uses a VERSION variable to indicate the version that the
lavadexecutable will report. It can be set by the command line (e.g. VERSION=0.4.1 make) or detected from the current checked-out code (as the most recent tag). However, it did not verify that the VERSION (requested/detected) matches the current code, and that the current code is clean.The Makefile now checks that the VERSION matches that of the current code, and that there are no uncommited changes or untracked files.
Run 'make' on with matching and matching versions, and on clean and dirty code trees.