Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): create config package #589

Merged
merged 5 commits into from
Apr 6, 2023
Merged

feat(config): create config package #589

merged 5 commits into from
Apr 6, 2023

Conversation

dk1a
Copy link
Member

@dk1a dk1a commented Apr 5, 2023

similar to #584 but config has no solidity/forge

@dk1a dk1a requested review from alvrs and holic as code owners April 5, 2023 10:35
alvrs
alvrs previously approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@alvrs alvrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just tiny nits

packages/config/.gitignore Outdated Show resolved Hide resolved
packages/config/.nvmrc Outdated Show resolved Hide resolved
@holic holic mentioned this pull request Apr 6, 2023
Closed
@dk1a @roninjin10
chore(config): update comment
cf64089 
Co-authored-by: Will Cory <willcory10@gmail.com>
@dk1a dk1a merged commit d2a23a6 into main Apr 6, 2023
@dk1a dk1a deleted the dk1a/config-init branch May 9, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roninjin10 roninjin10 roninjin10 left review comments

@holic holic holic approved these changes

@alvrs alvrs alvrs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dk1a @holic @roninjin10 @alvrs