-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugins): create plugins package #584
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call on moving this to a separate PR!
so would the ECS plugin basically hook into the default config and change stuff there when imported? |
yeah I think a separate entry would be easier to both implement and see what's happening. ecs stuff would also be not so much a plugin, as config wrapper that uses plugins. Well it can have a dedicated plugin too if needed |
packages/world-plugins/package.json
Outdated
@@ -0,0 +1,38 @@ | |||
{ | |||
"name": "@latticexyz/world-plugins", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we mark this private for now? or otherwise "hide" this from the lerna release flow so canaries can work until we have an actual package here?
what kind of world plugins are we thinking about? have we considered how the plugin API will look? |
current modules, tsgen, prototypes
not in any details, I'll probably improvise a PR and we can go from there |
i'd propose waiting with merging this one until we have a clearer picture of the plugin system |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Updated this to match other |
I think the order of operations should be
So i'm gonna temporarily close this to declutter the PR list, but generally think this is good and we can just reopen when it's time to merge it |
Stub so that boilerplate diffs and discussion don't have to be in the actual plugins PR
@roninjin10 I tried to account for #514 already
The idea with the dep chain:
schema-type
->store
->world
->config
->world-plugins
->config defaults
.cli
would be afterconfig
, and probably afterconfig defaults
.cli
andconfig
separation is unimplemented.config defaults
is unimplemented, I think the ECS wrapper @ludens had in mind would fit here, as well as some more general default for any kind of tables