feat(world): add FunctionSignatures offchain table

[alvrs]

The FunctionSelectors offchain table now stores a mapping from function selector to signature for all methods registered in the World. This will enable the automatic generation of interfaces for a given world address in the future.

[changeset-bot]

🦋 Changeset detected

Latest commit: cdc056e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages

Name	Type
@latticexyz/cli	Major
@latticexyz/world	Major
@latticexyz/dev-tools	Major
@latticexyz/store-sync	Major
@latticexyz/store-indexer	Major
@latticexyz/abi-ts	Major
@latticexyz/block-logs-stream	Major
@latticexyz/common	Major
@latticexyz/config	Major
create-mud	Major
@latticexyz/ecs-browser	Major
@latticexyz/faucet	Major
@latticexyz/gas-report	Major
@latticexyz/network	Major
@latticexyz/noise	Major
@latticexyz/phaserx	Major
@latticexyz/protocol-parser	Major
@latticexyz/react	Major
@latticexyz/recs	Major
@latticexyz/schema-type	Major
@latticexyz/services	Major
@latticexyz/solecs	Major
solhint-config-mud	Major
solhint-plugin-mud	Major
@latticexyz/std-client	Major
@latticexyz/std-contracts	Major
@latticexyz/store-cache	Major
@latticexyz/store	Major
@latticexyz/utils	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[alvrs]

Current dependencies on/for this PR:

• main
  • PR feat(world): change registerFunctionSelector signature to accept system signature as a single string #1574
    • PR feat(world): add FunctionSignatures offchain table #1575 👈

This comment was auto-generated by Graphite.

[holic]

Should this be just “register root function”? And the non root one “register function”?

[alvrs]

i personally find it more intuitive to keep the selector, since what happens is that a new function selector is added to the world contract (it's debatable, but there isn't really a new function added to the world, the function is part of the system and it was already possible to call it before a function selector was registered for it)

[holic]

but we are effectively adding a function to the world, regardless of how it’s implemented

I kinda like that “register function” communicates “world is mutable/extendable”

but happy to keep as is if you feel strongly

[alvrs]

In my mind we're just adding a "link" to an existing function by adding a new "function selector" to the World here. The World was extended when the system was registered (and it's even cheaper to call a function via the World's call function than going the indirection over the "function selector link" in the World)

[holic]

ohh I see, we're aliasing a function's name? I thought this is what system registration used to enable you to call the system methods via the world

[holic]

Beaut!

The base branch was changed.

[alvrs]

✅ (only gas report changed since last approval)