feat(world): change registerFunctionSelector signature to accept system signature as a single string

[alvrs]

• registerFunctionSelector now accepts the system function signature as a single string. There was no point in separating name and arguments.

[changeset-bot]

🦋 Changeset detected

Latest commit: d094f5b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages

Name	Type
@latticexyz/cli	Major
@latticexyz/world	Major
@latticexyz/dev-tools	Major
@latticexyz/store-sync	Major
@latticexyz/store-indexer	Major
@latticexyz/abi-ts	Major
@latticexyz/block-logs-stream	Major
@latticexyz/common	Major
@latticexyz/config	Major
create-mud	Major
@latticexyz/ecs-browser	Major
@latticexyz/faucet	Major
@latticexyz/gas-report	Major
@latticexyz/network	Major
@latticexyz/noise	Major
@latticexyz/phaserx	Major
@latticexyz/protocol-parser	Major
@latticexyz/react	Major
@latticexyz/recs	Major
@latticexyz/schema-type	Major
@latticexyz/services	Major
@latticexyz/solecs	Major
solhint-config-mud	Major
solhint-plugin-mud	Major
@latticexyz/std-client	Major
@latticexyz/std-contracts	Major
@latticexyz/store-cache	Major
@latticexyz/store	Major
@latticexyz/utils	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[alvrs]

Current dependencies on/for this PR:

• main
  • PR feat(world): change registerFunctionSelector signature to accept system signature as a single string #1574 👈
    • PR feat(world): add FunctionSignatures offchain table #1575

This comment was auto-generated by Graphite.

[holic]

is it important to call this “system” here? I noticed the method doesn’t mention system

[holic]

I see now that there’s a difference between world and system function signatures/selectors so clarifying here makes sense. I suggested a change to the function name in the other PR

[alvrs]

there is a nuance here that the naming is trying to make explicit: you're passing the signature of the function in the system contract (e.g. increment()), but the resulting world function signature will be <namespace>_<systemName>_increment()! That's why the returned selector is called worldFunctionSelector

Edit: didn't see your second reply before posting my reply

[holic]

So much nicer