[1.x] Don't error when docker is not available #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I considered reverting the change, but I think this feature is really worth-while, especially for new users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a misleading error message caused by #467.
When installing Laravel via laravel.build, the
sail:installcommand is run inside a temporary container (source). When inside this container, thedocker pullanddocker buildcommands fail and display a message saying "Is Docker running?" which is misleading. The installation continues regardless of this error, leaving the installation in the same state as prior to #467.It's non-trivial to run Docker commands inside a container, so this PR just adds a guard that silently returns if Docker is not available, instead of displaying the error. The logic for determining the presence of Docker is the same as the sail command itself.
I have created a separate PR for laravel.build that adds the functionality from #467 when using that installation method.