Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and pull sail services on installation #11

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

jessarcher
Copy link
Member

In laravel/sail#467 I made the sail:install command automatically build and pull the required services so that the first sail up can start serving immediately.

However, when installing Laravel Sail via laravel.build, the sail:install command is run inside a temporary container where it cannot run the docker commands 🤦‍♀️

I have created laravel/sail#468 that prevents sail:install from attempting to run the docker commands when docker is not available.

This PR adds that same functionality to laravel.build so that the first sail up starts serving immediately, no matter how you install Laravel Sail.

@jessarcher
Copy link
Member Author

I have confirmed that if the ./vendor/bin/sail commands fail, the rest of the installation still proceeds. The worst-case scenario is that the initial sail up will have to do the "build and pull" itself.

@taylorotwell taylorotwell merged commit 07c9364 into master Aug 17, 2022
@taylorotwell taylorotwell deleted the sail-pull-and-build branch August 17, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants