Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] Simplify hasNotFailedPreviousRuleIfPresenceRule , getDateTimestamp methods #53034

Closed
wants to merge 4 commits into from
Closed

[11.x] Simplify hasNotFailedPreviousRuleIfPresenceRule , getDateTimestamp methods #53034

wants to merge 4 commits into from
+2 −4

Commits on Oct 4, 2024

  1. refactor: Simplify getDateTimestamp by using null-safe operator directly

    @saMahmoudzadeh
    saMahmoudzadeh committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    5d70654 View commit details
    Browse the repository at this point in the history

  2. refactor: Simplify condition in hasNotFailedPreviousRuleIfPresenceRul… 

    …e method

- Removed the ternary operator and replaced it with a logical OR.
- Improved readability and performance by avoiding redundant conditions.
    @saMahmoudzadeh
    saMahmoudzadeh committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    45da166 View commit details
    Browse the repository at this point in the history

  3. fix code style

    @saMahmoudzadeh
    saMahmoudzadeh committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c0272b0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'refs/heads/11.x' into refactor

    @saMahmoudzadeh
    saMahmoudzadeh committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b8d1d54 View commit details
    Browse the repository at this point in the history