[11.x] Simplify hasNotFailedPreviousRuleIfPresenceRule , getDateTimestamp methods #53034
+2
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First Change:
Refactored the
getDateTimestamp
method to use the nullsafe operator (?->
) directly on the result ofgetDateTime($value)
. This change eliminates the need for an explicit null check and simplifies the code.is_null
check and redundant null assignment.Second Change:
Refactored the
hasNotFailedPreviousRuleIfPresenceRule
method to simplify the condition by replacing the ternary operator with a direct logical OR (||
) expression. This change makes the code more readable and reduces unnecessary complexity.