[5.7] Add Builder::whereJsonLength() #25047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
TBlindaruk
reviewed
Sep 5, 2018
| */ | ||
| protected function compileJsonLength($column, $operator, $value) | ||
| { | ||
| list($field, $path) = $this->wrapJsonFieldAndPath($column); |
There was a problem hiding this comment.
maybe will be better to use [$field, $path] instead list($field, $path) ?
|
It would be nice to have a section in the documentation that demonstrate all of these JSON methods. @staudenmeir do you think you could start a PR for that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen multiple people asking about queries on JSON columns that find (non-)empty arrays.
This PR brings
whereJsonLength()to MySQL 5.7, PostgreSQL 9.3, SQLite 3.9.0 and SQL Server 2016:On MySQL and SQL Server, this can also be used to count the keys in JSON objects.
The MySQL implementation is already designed to work on MariaDB.
wrapJsonFieldAndPath()returning an array instead of a string is also a preparation for bringing JSON support to MariaDB (commit for 5.7).As with the other JSON query features, there are no integration tests (#24330, #24672, #25328).