[5.6] Add Builder::whereJsonContains() #24330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-submit of #24258 to discuss your comment about better tests:
I assume that you mean integration tests? As far as I see, we don't support these for MySQL/PostgreSQL.
I agree that only testing the generated SQL isn't ideal, but I don't know how to improve it (of course, I tested the code with real databases).
For the future: Is a re-submit your preferred way to ask about a closed PR?