[5.6] Fix whereTime method for SQLiteGrammar with correct formatting. #23321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strftime('time', created_at)
is not working for sqlite and we need to apply correct formatting%H:%M:%S
.Currently,
->whereTime()
method does nothing and no filtering is performed.SQLite's strftime function accepts formatting string. Passing 'time' to it returns 'time' string instead of expected
%H:%M:%S
formatted time string.In example, comparing 'time' string and provided time like '12:00' does nothing.
It's a bug.
->whereTime()
function doesn't works as expected when using sqlite. So, it should be merged to 5.5 LTS too, I think.You can read more about sqlite date functions here: https://www.sqlite.org/lang_datefunc.html