[5.5] Fix SQLiteGrammar whereTime method with correct formatting.

[pinguinjkeke]

strftime('time', created_at) is not working for sqlite and we need to apply correct formatting %H:%M:%S.

It also should be merged to 5.6 and master branches.

You can read more about sqlite date functions here: https://www.sqlite.org/lang_datefunc.html

[sisve]

What is the current behavior, and how can we be sure that this doesn't cause problems for existing installations?

[pinguinjkeke]

@sisve currently, ->whereTime() method does nothing and no filtering is performed.

SQLite's strftime function accepts formatting string. Passing 'time' to it returns 'time' string instead of expected %H:%M:%S formatted time string.
In example, comparing 'time' string and provided time like '12:00' does nothing.

[taylorotwell]

Wrong branch. 5.6 is the current release.

[pinguinjkeke]

@taylorotwell It's a bugfix. Shouldn't it be merged to current LTS version?

From Laravel contribution doc:
All bug fixes should be sent to the latest stable branch or to the current LTS branch (5.5). Bug fixes should never be sent to the master branch unless they fix features that exist only in the upcoming release.

[pinguinjkeke]

@taylorotwell it should be merged with #23321

[pinguinjkeke]

@sisve @taylorotwell ping

[sisve]

I do not have the power of merging. Try sending a new PR with identical content.