Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] class_uses_recursive() return parent class's trait first #22537

Merged
merged 2 commits into from
Dec 26, 2017

Conversation

zhwei
Copy link
Contributor

@zhwei zhwei commented Dec 26, 2017

Reason

when Model booting traits, subclass's trait will boot before parent's trait, It is quite different from dev's expectation.


Changed

  • This PR will make class_uses_recursive() return traits order by use order.
  • PHPUnit assertEquals does not validate the order of array elements , so i change to assertSame

repeat #22536

@GrahamCampbell GrahamCampbell changed the title class_uses_recursive() return parent class's trait first [5.6] class_uses_recursive() return parent class's trait first Dec 26, 2017
@taylorotwell taylorotwell merged commit 1b4e49b into laravel:master Dec 26, 2017
@zhwei zhwei deleted the master branch December 27, 2017 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants