[5.5] class_uses_recursive() return parent class's trait first #22536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carusogabriel
suggested changes
Dec 26, 2017
tests/Support/SupportHelpersTest.php
Outdated
| @@ -699,20 +699,27 @@ public function testLast() | |||
|
|
|||
| public function testClassUsesRecursiveShouldReturnTraitsOnParentClasses() | |||
| { | |||
| $this->assertEquals([ | |||
| 'Illuminate\Tests\Support\SupportTestTraitOne' => 'Illuminate\Tests\Support\SupportTestTraitOne', | |||
| $this->assertTrue([ | |||
There was a problem hiding this comment.
Use assertSame instead. It checks strict.
carusogabriel
approved these changes
Dec 26, 2017
|
This sounds like a breaking change and something that should target the 5.6 release (the master branch). |
|
I think this should be a Bug, In my case, subclass boot depend on the data generated by parent class's boot. On the contrary, parent class's boot certainly not depend on subclass's boot. |
|
You're not changing just how model traits are initiated, you are changing how the global helper class_uses_recursive works. This could affect a lot more things that just your specific scenario. Thus I argue that it should target the 5.6 release and be documented as a change in the upgrade guide. |
|
ok |
|
new PR is #22537 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
when Model booting traits, subclass's trait will boot before parent's trait, It is quite different from dev's expectation.
Changed
class_uses_recursive()return traits order byuseorder.assertEqualsdoes not validate the order of array elements , so i change toassertSame