[5.5] Clear "select" bindings whenever select columns have been override. #21486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for not writing a detailed description in last PR #21485
This PR revert some changes in last fix #21468. And add the code call
->setBindings([], 'select')
whenselect()
being called to fix an issue for cases query builder originally have select bindings but later being override cause a binding mismatch issue that lead to error.The quickest way to reproduce error is run this in tinker
$query
will have bindings[1]
.if later call
$query
will have bindings[1, "bar"]
while it supposed to only have["bar"]
@themsaid let me know your thoughts, thanks!
reference: #21472